Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migration #122 set useTransactionSimulations to true #25768

Closed

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jul 11, 2024

Description

This migration sets useTransactionSimulations to true. Some users may have explicitly turned off the experimental setting, which this migration will reset to true. This is intentional as we also plan to remove the setting in an upcoming release.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Turn off the Experimental > Improved signature redesign setting
  2. Run newest version with migration
  3. Observe setting has been turned on

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner July 11, 2024 13:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.2% Duplication on New Code (required ≤ 7%)

See analysis details on SonarCloud

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 11, 2024
@digiwand digiwand closed this Jul 11, 2024
@digiwand digiwand deleted the feat-migration-122-useTransactionSimulations branch July 11, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants