Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ramps dev environment on Flask #25659

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Jul 3, 2024

Description

Allow https://ramps-dev.portfolio.metamask.io send requests to non-EVM account Snaps on Flask.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/509

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danroc danroc requested a review from a team as a code owner July 3, 2024 14:52
Copy link
Contributor

github-actions bot commented Jul 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danroc danroc self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (e0db3ef) to head (90c9282).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25659   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1366     1366           
  Lines        48231    48231           
  Branches     13304    13304           
========================================
  Hits         33604    33604           
  Misses       14627    14627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [6a3259e]
Page Load Metrics (218 ± 226 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67151982010
domContentLoaded9392284
load431730218471226
domInteractive9392284
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [a174a16]
Page Load Metrics (260 ± 276 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722051123115
domContentLoaded107135199
load442382260575276
domInteractive107135199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

gantunesr
gantunesr previously approved these changes Jul 4, 2024
Copy link

sonarqubecloud bot commented Jul 4, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [90c9282]
Page Load Metrics (201 ± 251 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint843691245928
domContentLoaded117337209
load492476201522251
domInteractive117337209
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ccharly ccharly merged commit 31d0c3f into develop Jul 4, 2024
73 checks passed
@ccharly ccharly deleted the dr/portfolio-staging branch July 4, 2024 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants