Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates MMI custody controller #25631

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

zone-live
Copy link
Contributor

Description

Updates MMI controller to latest version, we've updated a method to filter out two custodians that are not used anymore.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Jul 2, 2024
@zone-live zone-live requested a review from a team as a code owner July 2, 2024 13:57
Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-institutional/[email protected] None +1 71.5 kB aregadas

🚮 Removed packages: npm/@metamask-institutional/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [17b8446]
Page Load Metrics (66 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint74138100178
domContentLoaded105726136
load4111766188
domInteractive105726136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live requested a review from albertolive July 2, 2024 15:15
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (7b69e3c) to head (1ee2bbf).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25631   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1366     1366           
  Lines        48215    48215           
  Branches     13301    13301           
========================================
  Hits         33588    33588           
  Misses       14627    14627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1ee2bbf]
Page Load Metrics (79 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint643161126632
domContentLoaded998292110
load40300796230
domInteractive998292110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 56c9dc2 into develop Jul 3, 2024
73 checks passed
@zone-live zone-live deleted the MMI-5198-update-custody-controller-package branch July 3, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants