feat(btc): add BTC account creation menu entry #25625

ccharly · 2024-07-02T10:06:44Z

Description

This adds a new menu entry "Create a new Bitcoin account" to create a Bitcoin account using the Bitcoin Manager Snap.

Note

This new feature is only available on Flask for now.

Warning

Some code logic of this PR might change depending if we are able to reduce the e2e test flakiness from this PR:

feat: define account name during creation #25191

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/451

Manual testing steps

Main build

yarn start
Click on the account (in the app header)
Click "Add account or hardware wallet"
You should not see anything related to Bitcoin account creation

Flask build

yarn start
Click on the account (in the app header)
Click "Add account or hardware wallet"
Click "Create a new Bitcoin account"
Input your account name
You should now see your new Bitcoin account in the extension

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-02T10:06:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-02T13:28:26Z

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (5ee57a6) to head (716861e).
Report is 19 commits behind head on develop.

Files	Patch %	Lines
.../multichain/account-list-menu/account-list-menu.js	54.17%	11 Missing ⚠️
ui/store/actions.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25625      +/-   ##
===========================================
- Coverage    69.77%   69.77%   -0.01%     
===========================================
  Files         1376     1378       +2     
  Lines        48403    48534     +131     
  Branches     13348    13383      +35     
===========================================
+ Hits         33773    33860      +87     
- Misses       14630    14674      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-02T13:39:22Z

Builds ready [f2ffffe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (241 ± 231 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	164	109	22	11
		domContentLoaded	9	79	30	15	7
		load	40	1775	241	481	231
		domInteractive	9	79	30	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.95 KiB (0.06%)
common: 68 Bytes (0.00%)

metamaskbot · 2024-07-02T16:22:57Z

Builds ready [93d5ee5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (167 ± 168 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	150	115	16	8
		domContentLoaded	11	80	35	17	8
		load	48	1691	167	350	168
		domInteractive	11	80	35	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.99 KiB (0.06%)
common: 68 Bytes (0.00%)

app/scripts/lib/snap-keyring/bitcoin-manager-snap.ts

ui/components/multichain/create-btc-account/create-btc-account.tsx

montelaidev · 2024-07-09T09:33:51Z

Tested and the account creation with the preinstalled flask is working. The only issue is with the asset icon

metamaskbot · 2024-07-10T11:51:58Z

Builds ready [ed06ecc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (73 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	132	100	17	8
		domContentLoaded	9	62	30	15	7
		load	42	108	73	19	9
		domInteractive	9	62	30	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 521.34 KiB (7.46%)
common: 68 Bytes (0.00%)

ccharly · 2024-07-10T11:57:42Z

Tested and the account creation with the preinstalled flask is working. The only issue is with the asset icon

@montelaidev Yes the asset icon is not showing during balance's loading (same behavior than for eth actually)

gantunesr · 2024-07-10T13:10:04Z

@ccharly - If the account was already created, the button "Add new Bitcoin account" should be disabled. Once the account is deleted/removed, the button should be enabled again

app/_locales/en/messages.json

Co-authored-by: Daniel Rocha <[email protected]>

ccharly · 2024-07-10T14:28:50Z

@ccharly - If the account was already created, the button "Add new Bitcoin account" should be disabled. Once the account is deleted/removed, the button should be enabled again

@gantunesr yup, just implemented it here: 5a196a0

But I had to wait for other PRs to be merged! :)

sonarcloud · 2024-07-10T15:01:40Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-10T15:43:05Z

Builds ready [716861e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (63 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	153	93	21	10
		domContentLoaded	9	63	24	14	7
		load	39	115	63	19	9
		domInteractive	9	63	24	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 521.6 KiB (7.47%)
common: 75 Bytes (0.00%)

metamaskbot · 2024-07-10T15:56:08Z

Builds ready [716861e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (63 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	153	93	21	10
		domContentLoaded	9	63	24	14	7
		load	39	115	63	19	9
		domInteractive	9	63	24	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 521.6 KiB (7.47%)
common: 75 Bytes (0.00%)

montelaidev · 2024-07-10T15:59:41Z

Tested again, and the menu entry is now disabled after the account creation.

ccharly added 3 commits July 2, 2024 09:25

refactor: better typing for handleSnapRequest

54db504

feat(btc): add CreateBtcAccount component

448b28e

feat(btc): add [email protected] as a preinstalled snap

ab68a06

ccharly added the team-accounts label Jul 2, 2024

ccharly added 3 commits July 2, 2024 12:08

refactor(btc): only add btc account menu entry for flask

11edb03

chore: ignore prettier for app/scripts/snaps/*.json

9216114

chore: lint

2ab28e7

ccharly force-pushed the feature/create-btc-account-without-snap-flow branch from 68f81e7 to 2ab28e7 Compare July 2, 2024 10:08

ccharly added 5 commits July 2, 2024 12:13

fix(storybook): fix title for Create{Btc,Eth}Account

f73c467

refactor: use new addAccount value everywhere

afc2d35

fix(btc): call onActionComplete after account has been created + renamed

c8ca2a7

test(btc): fix CreateBtcAccount tests

ac85ac7

chore: lint

f2ffffe

ccharly force-pushed the feature/create-btc-account-without-snap-flow branch from 91b06a0 to f2ffffe Compare July 2, 2024 13:04

danroc assigned ccharly Jul 2, 2024

gantunesr marked this pull request as ready for review July 2, 2024 13:28

gantunesr requested review from a team as code owners July 2, 2024 13:28

ccharly added 2 commits July 2, 2024 15:44

Merge branch 'develop' into feature/create-btc-account-without-snap-flow

af7b143

fix(btc): fix initial account BTC creation

7b0b10b

ccharly force-pushed the feature/create-btc-account-without-snap-flow branch from e9d3e26 to 7b0b10b Compare July 2, 2024 15:05

test(btc): add missing mock for forceUpdateMetamaskState

93d5ee5

ccharly force-pushed the feature/create-btc-account-without-snap-flow branch from fa1bc6d to 93d5ee5 Compare July 2, 2024 15:39

ccharly added 2 commits July 2, 2024 18:27

Merge branch 'develop' into feature/create-btc-account-without-snap-flow

8c0a432

chore(btc): use bitcoin-manager-snap as a dependency

34a1e15

montelaidev reviewed Jul 9, 2024

View reviewed changes

app/scripts/lib/snap-keyring/bitcoin-manager-snap.ts Outdated Show resolved Hide resolved

app/scripts/lib/snap-keyring/bitcoin-manager-snap.ts Outdated Show resolved Hide resolved

ui/components/multichain/create-btc-account/create-btc-account.tsx Outdated Show resolved Hide resolved

ccharly added 2 commits July 9, 2024 17:17

Merge branch 'develop' into feature/create-btc-account-without-snap-flow

f05e23b

refactor(btc): use new preinstalled @metamask/bitcoin-wallet-snap Snap

fa37320

ccharly force-pushed the feature/create-btc-account-without-snap-flow branch from 6765647 to fa37320 Compare July 9, 2024 16:11

ccharly added 3 commits July 10, 2024 10:30

fix(btc): fix code fences

e63b0dd

fix(btc): fix BitcoinWalletSnap code fences

f929666

chore: revert changes to .prettierignore

ae79ece

ccharly removed the request for review from a team July 10, 2024 09:14

ccharly changed the title ~~feat(btc): add BTC account creation menu entry + BTC preinstalled snap (Flask only)~~ feat(btc): add BTC account creation menu entry Jul 10, 2024

Merge branch 'develop' into feature/create-btc-account-without-snap-flow

ed06ecc

fix(btc): disable menu entry if account has been already created

5a196a0

danroc reviewed Jul 10, 2024

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

chore: add " (Beta)" suffix

11f450e

Co-authored-by: Daniel Rocha <[email protected]>

ccharly added 2 commits July 10, 2024 16:29

chore: lint

eb4ea27

fix(btc): fix missing code fences

716861e

danroc approved these changes Jul 10, 2024

View reviewed changes

montelaidev approved these changes Jul 10, 2024

View reviewed changes

ccharly merged commit 059166b into develop Jul 10, 2024
73 checks passed

ccharly deleted the feature/create-btc-account-without-snap-flow branch July 10, 2024 16:00

github-actions bot locked and limited conversation to collaborators Jul 10, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(btc): add BTC account creation menu entry #25625

feat(btc): add BTC account creation menu entry #25625

ccharly commented Jul 2, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 2, 2024

codecov bot commented Jul 2, 2024 •

edited

Loading

metamaskbot commented Jul 2, 2024

metamaskbot commented Jul 2, 2024

montelaidev commented Jul 9, 2024

metamaskbot commented Jul 10, 2024

ccharly commented Jul 10, 2024

gantunesr commented Jul 10, 2024

ccharly commented Jul 10, 2024

sonarcloud bot commented Jul 10, 2024

metamaskbot commented Jul 10, 2024

metamaskbot commented Jul 10, 2024

montelaidev commented Jul 10, 2024

feat(btc): add BTC account creation menu entry #25625

feat(btc): add BTC account creation menu entry #25625

Conversation

ccharly commented Jul 2, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Main build

Flask build

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 2, 2024

codecov bot commented Jul 2, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 2, 2024

metamaskbot commented Jul 2, 2024

montelaidev commented Jul 9, 2024

metamaskbot commented Jul 10, 2024

ccharly commented Jul 10, 2024

gantunesr commented Jul 10, 2024

ccharly commented Jul 10, 2024

sonarcloud bot commented Jul 10, 2024

Quality Gate passed

metamaskbot commented Jul 10, 2024

metamaskbot commented Jul 10, 2024

montelaidev commented Jul 10, 2024

ccharly commented Jul 2, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 2, 2024 •

edited

Loading