-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramps): update isNativeTokenBuyable to include BTC #25621
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…aMask/metamask-extension into feature/btc-is-token-buyable
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25621 +/- ##
========================================
Coverage 69.67% 69.68%
========================================
Files 1366 1366
Lines 48233 48248 +15
Branches 13305 13307 +2
========================================
+ Hits 33606 33618 +12
- Misses 14627 14630 +3 ☔ View full report in Codecov by Sentry. |
Builds ready [785472f]
Page Load Metrics (61 ± 9 ms)
Bundle size diffs
|
Builds ready [1534cf9]
Page Load Metrics (302 ± 265 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment was marked as resolved.
This comment was marked as resolved.
LGTM for QA ✅ |
Description
isNativeTokenBuyable
function to consider bitcoinRelated issues
Fixes: #25657
Manual testing steps
The following QA steps will allow you to test the permutations of this feature:
Verify that ERC20 Ramps card is still working for 0 balance accounts
Verify ERC20 Ramps card is hidden for accounts with > 0 token balance
Verify that BTC Ramps card is working
.metamaskrc
to access ramps UATVerify that BTC Ramps card is hidden for accounts with > 0 BTC
.metamaskrc
to access ramps UATVerify that BTC Ramps card is hidden in PROD for all accounts
.metamaskrc
to access ramps PRODScreenshots/Recordings
BTC card appears for 0 balance accounts:
BTC card does not appear for > 0 balance:
Pre-merge author checklist
Pre-merge reviewer checklist