Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated mixins with text component in transaction-confirmed #25551

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 27, 2024

Description

This pull request replaces deprecated mixins with the Text component in the transaction-confirmed.component.js file. The padding values in the Text components have been updated to 4.

Devin Run Link: https://staging.itsdev.in/devin/0bf228de1dc64981adb90e7ac712d1e7

Open in GitHub Codespaces

Related issues

Partially Fixes: #20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Manually check if TransactionConfirmed is getting rendered correctly

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (721673e) to head (04b5172).
Report is 276 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25551   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1350     1350           
  Lines        47865    47865           
  Branches     13199    13199           
========================================
  Hits         33355    33355           
  Misses       14510    14510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [04b5172]
Page Load Metrics (47 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6211480126
domContentLoaded8271142
load38634773
domInteractive8271142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 158 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@consensys-devin
Copy link

Tagging @georgewrmarshall for review

@georgewrmarshall georgewrmarshall requested a review from a team June 28, 2024 17:02
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 28, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 28, 2024 17:02
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 28, 2024 17:02
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one small suggestion

@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

Copy link

sonarcloud bot commented Jul 31, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [741695c]
Page Load Metrics (275 ± 247 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint633261117034
domContentLoaded95518136
load381550275515247
domInteractive95518136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 35 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • checked storybook ✅

@garrettbear garrettbear merged commit 728b0e4 into develop Aug 1, 2024
75 checks passed
@garrettbear garrettbear deleted the devin/mixin-565343 branch August 1, 2024 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 1, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component
5 participants