-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated mixins with text component in transaction-confirmed #25551
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25551 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1350 1350
Lines 47865 47865
Branches 13199 13199
========================================
Hits 33355 33355
Misses 14510 14510 ☔ View full report in Codecov by Sentry. |
Builds ready [04b5172]
Page Load Metrics (47 ± 3 ms)
Bundle size diffs
|
Tagging @georgewrmarshall for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made one small suggestion
ui/components/app/modals/transaction-confirmed/transaction-confirmed.component.js
Outdated
Show resolved
Hide resolved
…firmed.component.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions
ui/components/app/modals/transaction-confirmed/transaction-confirmed.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/modals/transaction-confirmed/transaction-confirmed.component.js
Outdated
Show resolved
Hide resolved
…firmed.component.js
…firmed.component.js
Quality Gate passedIssues Measures |
Builds ready [741695c]
Page Load Metrics (275 ± 247 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- checked storybook ✅
Description
This pull request replaces deprecated mixins with the Text component in the
transaction-confirmed.component.js
file. The padding values in the Text components have been updated to 4.Devin Run Link: https://staging.itsdev.in/devin/0bf228de1dc64981adb90e7ac712d1e7
Related issues
Partially Fixes: #20496
Manual testing steps
TransactionConfirmed
is getting rendered correctlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist