Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix network delete trash displayed on mouse over #25547

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 27, 2024

Description

the delete network trash logo should be displayed only when we have mouse over

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add any popular network
  2. Go to network modal
  3. check if the trash icon is displayed without mouse over

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner June 27, 2024 08:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 27, 2024
@salimtb salimtb changed the title fix: fix network delete trash mouse over fix: fix network delete trash displayed on mouse over Jun 27, 2024
@salimtb salimtb requested a review from darkwing June 27, 2024 08:49
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (6918c52) to head (a90d020).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25547   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1349     1349           
  Lines        47850    47850           
  Branches     13195    13195           
========================================
  Hits         33337    33337           
  Misses       14513    14513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a90d020]
Page Load Metrics (129 ± 170 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6613583168
domContentLoaded9241242
load381670129354170
domInteractive9241242
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb merged commit d91bb02 into develop Jun 27, 2024
80 of 81 checks passed
@salimtb salimtb deleted the fix-delete-network-mouse-over branch June 27, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants