fix: Cannot destructure property 'balance' of 'K[Z]' as it is undefined fromAddress error when no transaction is loaded in ConfirmTransactionBase

[digiwand]

Description

In confirm-transaction-base.container.js, while the transaction is switching, the component may be in a state without transaction data. In this case, we can handle the empty transaction data appropriately until the expected data comes in to allow the user flow to continue without breaking.

note: I was unable to reproduce this in develop after some time, but I successfully repro'd this in Version-v12.0.0 which allowed me to verify the fix works. Possibly the underlying empty transaction data state was fixed by other code in develop

This PR is planned to be cherry-picked for Version-v12.0.0

Related issues

Fixes: #25406

Manual testing steps

See Issue for repro steps

Screenshots/Recordings

Possible, occasional state in confirm-transaction-base.container.js

Before

See error in Issue screenshots

After

No error message is shown and app works as expected

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (d403213) to head (e422925).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
...saction-base/confirm-transaction-base.container.js	66.67%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25506      +/-   ##
===========================================
- Coverage    69.69%   69.68%   -0.00%     
===========================================
  Files         1350     1350              
  Lines        47865    47867       +2     
  Branches     13199    13201       +2     
===========================================
+ Hits         33355    33356       +1     
- Misses       14510    14511       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [2667021]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (135 ± 167 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	132	90	17	8
		domContentLoaded	9	34	14	6	3
		load	41	1648	135	347	167
		domInteractive	9	34	14	6	3

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 4 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sleepytanya]

@digiwand
MetaMask now doesn't break with an error but the subsequent transaction is created on the same chain as the previous one.
First scenario from the bug ticket:

• Connect to the test dapp with Sepolia
• Connect to dapp with Ethereum
• Trigger a swap in dapp
• Without accepting/rejecting, go to the test dapp and trigger a signature - signature request from the test dapp is created on mainnet

swapSign.mov

Error also doesn't appear for this scenario, Connect request is lost, instead of blue numbers there is '...' on the MM icon.

• Connect to test-dapp
• Click button to start legacy send transaction; popup comes up, I see a "1" in the extension icon, I ignore the popup window
• Open new tab, go to Uniswap
• Click "Connect" button, click MetaMask; I see a "2" in the extension icon, no popup occurs
• Click "Connect" button again, click MetaMask; I see a "3" in the extension icon, no popup occurs
• After the first request is rejected and the subsequent request can be accessed MM can break with an error

Screen.Recording.2024-06-25.at.16.26.35.mov

Error also doesn't happen for these steps:

• Start send+swap txs with low gas
• Send another (approve) tx from a dapp
• Confirmation is stuck on the spinner
• Activity tab has two txs - Pending and Unapproved
• Unapprovedtxs can't be rejected
• If user rejects first tx MM displays an error Cannot destructure property 'balance' of 'Q[z]' as it is undefined.

[digiwand]

Great catch @sleepytanya! Q: were you able to repro the bug on the develop branch? I was unable to do this so I wonder if it was fixed by develop and not added to v12.0.0

[digiwand]

@sleepytanya I have repro'd the issue on develop. We will need to further investigate a fix for this

[sleepytanya]

@digiwand @darkwing @bschorchit
This issue is now resolved across all scenarios we have identified. I will create a separate ticket for the issue with the signature generated on the wrong network.

[metamaskbot]

Builds ready [99d49c8]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (279 ± 316 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	216	105	40	19
		domContentLoaded	9	49	16	10	5
		load	39	2526	279	659	316
		domInteractive	9	49	16	10	5

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 298 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [e422925]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (52 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	106	86	12	6
		domContentLoaded	9	27	12	4	2
		load	40	69	52	9	4
		domInteractive	9	27	12	4	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 298 Bytes (0.00%)
• common: 0 Bytes (0.00%)