-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump @metamask/queued-request controller
to ^2.0.0
to fix confirmation popup focus in request queue
#25497
feat: bump @metamask/queued-request controller
to ^2.0.0
to fix confirmation popup focus in request queue
#25497
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
…firmation-popup-focus
…firmation-popup-focus
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25497 +/- ##
========================================
Coverage 69.65% 69.65%
========================================
Files 1347 1347
Lines 47805 47803 -2
Branches 13186 13184 -2
========================================
- Hits 33297 33296 -1
+ Misses 14508 14507 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [f96d58e]
Page Load Metrics (48 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…firmation-popup-focus
…firmation-popup-focus
Builds ready [ddb1787]
Page Load Metrics (42 ± 1 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Related issues
See: MetaMask/core#4457
See: #25397
Manual testing steps
await window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "0xaa36a7"}]})
in console to change the network to sepolia for this dappawait window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "1"}]})
in console to change the network to mainnet for this dappawait window.ethereum.request({method: 'eth_requestAccounts'})
Screenshots/Recordings
Before
After
Screen.Recording.2024-06-24.at.2.22.07.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist