feat: upgrade assets controllers to version 33 #25484

bergeron · 2024-06-24T01:36:14Z

Description

Upgrades assets controllers from version 30 to 33. See the package's changelog for details.

Related issues

Manual testing steps

Test token detection, token prices, NFT detection

Screenshots/Recordings

No visible differences

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-24T01:36:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-06-24T01:37:19Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	Transitive: environment	`+22`	4.12 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

bergeron · 2024-06-24T03:00:56Z

@metamaskbot update-policies

metamaskbot · 2024-06-24T03:09:18Z

Policies updated

… brian/upgrade-assets-controllers-33

metamaskbot · 2024-06-24T21:25:45Z

Builds ready [695798e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (139 ± 171 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	201	95	26	13
		domContentLoaded	10	29	13	4	2
		load	44	1689	139	356	171
		domInteractive	10	29	13	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -4.52 KiB (-0.13%)
ui: 0 Bytes (0.00%)
common: 36.23 KiB (0.56%)

codecov · 2024-06-24T21:25:52Z

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (d403213) to head (99b03f1).

Files	Patch %	Lines
app/scripts/metamask-controller.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25484      +/-   ##
===========================================
- Coverage    69.69%   69.68%   -0.01%     
===========================================
  Files         1350     1350              
  Lines        47865    47865              
  Branches     13199    13199              
===========================================
- Hits         33355    33352       -3     
- Misses       14510    14513       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… brian/upgrade-assets-controllers-33

bergeron · 2024-06-25T15:26:37Z

@metamaskbot update-policies

metamaskbot · 2024-06-25T15:37:38Z

Policies updated

metamaskbot · 2024-06-25T16:13:16Z

Builds ready [ea99f11]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (54 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	105	85	9	4
		domContentLoaded	10	14	11	1	0
		load	44	74	54	7	3
		domInteractive	10	14	11	1	0

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 883 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 41.37 KiB (0.64%)

… brian/upgrade-assets-controllers-33

bergeron · 2024-06-26T15:39:32Z

@metamaskbot update-policies

metamaskbot · 2024-06-26T15:45:55Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-06-26T15:47:07Z

@metamaskbot update-policies

metamaskbot · 2024-06-26T15:53:26Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-06-26T16:29:19Z

@metamaskbot update-policies

metamaskbot · 2024-06-26T16:36:08Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-06-26T20:20:17Z

@metamaskbot update-policies

metamaskbot · 2024-06-26T20:26:43Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-06-26T20:48:42Z

@metamaskbot update-policies

metamaskbot · 2024-06-26T20:55:07Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-06-27T02:58:23Z

@metamaskbot update-policies

metamaskbot · 2024-06-27T03:09:17Z

Policies updated

… brian/upgrade-assets-controllers-33

bergeron · 2024-06-27T14:02:21Z

@metamaskbot update-policies

metamaskbot · 2024-06-27T14:15:40Z

No policy changes

metamaskbot · 2024-06-27T14:31:38Z

Builds ready [99b03f1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (55 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	140	90	14	7
		domContentLoaded	10	16	11	2	1
		load	41	111	55	15	7
		domInteractive	10	16	11	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 883 Bytes (0.03%)
ui: 0 Bytes (0.00%)
common: 41.37 KiB (0.64%)

salimtb · 2024-06-27T14:47:31Z

just did a QA on the branch, everything work as expected

feat: upgrade assets controllers to version 33

537cb44

bergeron added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 24, 2024

bergeron requested review from sahar-fehri and salimtb June 24, 2024 01:36

bergeron requested a review from a team as a code owner June 24, 2024 01:36

bergeron added 3 commits June 23, 2024 18:43

fix missing action

d7ea726

fix unit test

ded32c6

fix unit test

65ea16b

Update LavaMoat policies

9a08129

metamaskbot requested review from a team as code owners June 24, 2024 03:09

bergeron added 3 commits June 24, 2024 08:31

Merge branch 'develop' into brian/upgrade-assets-controllers-33

abe67d5

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

0879715

… brian/upgrade-assets-controllers-33

fix e2e test

695798e

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

b35841c

… brian/upgrade-assets-controllers-33

Update LavaMoat policies

ea99f11

bergeron added 2 commits June 26, 2024 08:39

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

e5df0af

… brian/upgrade-assets-controllers-33

yarn

2c5ab98

yarn

91d51cb

Merge branch 'develop' into brian/upgrade-assets-controllers-33

e192f9e

Update LavaMoat policies

7511f38

bergeron added 2 commits June 27, 2024 07:01

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

dd6939a

… brian/upgrade-assets-controllers-33

yarn

99b03f1

salimtb approved these changes Jun 27, 2024

View reviewed changes

sahar-fehri approved these changes Jun 27, 2024

View reviewed changes

bergeron merged commit c5d6593 into develop Jun 27, 2024
70 checks passed

bergeron deleted the brian/upgrade-assets-controllers-33 branch June 27, 2024 15:03

github-actions bot locked and limited conversation to collaborators Jun 27, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade assets controllers to version 33 #25484

feat: upgrade assets controllers to version 33 #25484

bergeron commented Jun 24, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jun 24, 2024

socket-security bot commented Jun 24, 2024 •

edited

Loading

bergeron commented Jun 24, 2024

metamaskbot commented Jun 24, 2024

metamaskbot commented Jun 24, 2024

codecov bot commented Jun 24, 2024 •

edited

Loading

bergeron commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

bergeron commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

salimtb commented Jun 27, 2024

feat: upgrade assets controllers to version 33 #25484

feat: upgrade assets controllers to version 33 #25484

Conversation

bergeron commented Jun 24, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 24, 2024

socket-security bot commented Jun 24, 2024 • edited Loading

bergeron commented Jun 24, 2024

metamaskbot commented Jun 24, 2024

metamaskbot commented Jun 24, 2024

codecov bot commented Jun 24, 2024 • edited Loading

Codecov Report

bergeron commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 26, 2024

metamaskbot commented Jun 26, 2024

bergeron commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

bergeron commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

metamaskbot commented Jun 27, 2024

salimtb commented Jun 27, 2024

bergeron commented Jun 24, 2024 •

edited by github-actions bot

Loading

socket-security bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading