-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix large amount display #25464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
force-pushed
the
fix-token-amount-display
branch
2 times, most recently
from
June 21, 2024 14:38
a4c3f86
to
2cbe9db
Compare
salimtb
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Jun 21, 2024
salimtb
force-pushed
the
fix-token-amount-display
branch
from
June 21, 2024 14:41
2cbe9db
to
d1fc7e2
Compare
salimtb
force-pushed
the
fix-token-amount-display
branch
from
June 21, 2024 14:46
d1fc7e2
to
c5b9ffb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25464 +/- ##
===========================================
- Coverage 64.91% 64.91% -0.00%
===========================================
Files 1390 1390
Lines 55155 55157 +2
Branches 14493 14493
===========================================
+ Hits 35803 35804 +1
- Misses 19352 19353 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [c5b9ffb]
Page Load Metrics (55 ± 4 ms)
Bundle size diffs
|
sahar-fehri
approved these changes
Jun 24, 2024
bergeron
approved these changes
Jun 24, 2024
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to fix the way we display large token amout
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist