Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix large amount display #25464

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: fix large amount display #25464

merged 1 commit into from
Jun 24, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 21, 2024

Description

The goal of this PR is to fix the way we display large token amout

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to wallet page
  2. Import a token with large amount
  3. check the way it's displayed

Screenshots/Recordings

Before

Screenshot 2024-06-21 at 15 30 22

After

Screenshot 2024-06-21 at 15 29 09

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner June 21, 2024 13:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the fix-token-amount-display branch 2 times, most recently from a4c3f86 to 2cbe9db Compare June 21, 2024 14:38
@salimtb salimtb added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jun 21, 2024
@salimtb salimtb force-pushed the fix-token-amount-display branch from 2cbe9db to d1fc7e2 Compare June 21, 2024 14:41
@salimtb salimtb force-pushed the fix-token-amount-display branch from d1fc7e2 to c5b9ffb Compare June 21, 2024 14:46
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (5c8e1a9) to head (c5b9ffb).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25464      +/-   ##
===========================================
- Coverage    64.91%   64.91%   -0.00%     
===========================================
  Files         1390     1390              
  Lines        55155    55157       +2     
  Branches     14493    14493              
===========================================
+ Hits         35803    35804       +1     
- Misses       19352    19353       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c5b9ffb]
Page Load Metrics (55 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6211288157
domContentLoaded9151121
load42785594
domInteractive9151121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 232 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb merged commit 64b8db4 into develop Jun 24, 2024
74 checks passed
@salimtb salimtb deleted the fix-token-amount-display branch June 24, 2024 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants