Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mmi circleCi config PW step #25440

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

zone-live
Copy link
Contributor

Description

We are missing a run of check-mmi-optional in the test-e2e-mmi-playwright step.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from kumavis and a team as code owners June 20, 2024 14:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the team-mmi PRs from the MMI team label Jun 20, 2024
@zone-live zone-live requested review from danjm and albertolive June 20, 2024 15:00
@metamaskbot
Copy link
Collaborator

Builds ready [58d08d2]
Page Load Metrics (118 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6710682115
domContentLoaded9151021
load411479118312150
domInteractive9151021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (aabd481) to head (58d08d2).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25440   +/-   ##
========================================
  Coverage    64.93%   64.93%           
========================================
  Files         1385     1385           
  Lines        54870    54870           
  Branches     14408    14408           
========================================
+ Hits         35625    35626    +1     
+ Misses       19245    19244    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live merged commit e29ed39 into develop Jun 20, 2024
80 checks passed
@zone-live zone-live deleted the MMI-adds-missing-step branch June 20, 2024 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants