-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable Smart Transactions for the new Send&Swap feature #25422
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -120,9 +121,16 @@ class SmartTransactionHook { | |||
} | |||
|
|||
async submit() { | |||
const isUnsupportedTransactionTypeForSmartTransaction = | |||
this.#transactionMeta.type && | |||
[TransactionType.swapAndSend].includes(this.#transactionMeta.type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could simplify to this.#transactionMeta?.type === TransactionType.swapAndSend
49986d9
to
df09d84
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25422 +/- ##
========================================
Coverage 64.92% 64.92%
========================================
Files 1382 1382
Lines 54764 54768 +4
Branches 14369 14371 +2
========================================
+ Hits 35551 35555 +4
Misses 19213 19213 ☔ View full report in Codecov by Sentry. |
Builds ready [df09d84]
Page Load Metrics (56 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
Description
Disables Smart Transactions for the new Send&Swap feature, since we don't support it there yet. Support will be added in one of the upcoming releases.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist