-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show paymaster address in redesigned contract interaction #25396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great 👍
Add info section component. Add contract interaction stories. Add paymaster address selector.
812797f
to
dd2f528
Compare
Add missing selector.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25396 +/- ##
===========================================
+ Coverage 64.91% 64.93% +0.01%
===========================================
Files 1390 1391 +1
Lines 55155 55177 +22
Branches 14493 14497 +4
===========================================
+ Hits 35803 35824 +21
- Misses 19352 19353 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [e06b707]
Page Load Metrics (42 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
can reapprove after the merge conflict is resolved
Builds ready [7b636f3]
Page Load Metrics (126 ± 169 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [080a644]
Page Load Metrics (43 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Display the paymaster address in the contract interaction confirmation.
Only if the transaction is a user operation and includes
paymasterAndData
.In addition:
Box
usages with newConfirmInfoSection
component.AlertRow
toConfirmInfoAlertRow
.Related issues
Fixes: #2673
Manual testing steps
ENABLE_CONFIRMATION_REDESIGN=true
to.metamaskrc
.Fee paid by
row is visible.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist