Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show paymaster address in redesigned contract interaction #25396

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jun 18, 2024

Description

Display the paymaster address in the contract interaction confirmation.

Only if the transaction is a user operation and includes paymasterAndData.

In addition:

  • Replace duplicate Box usages with new ConfirmInfoSection component.
  • Add stories for the full contract interaction confirmation page for easier testing.
  • Create selectors to retrieve paymaster data and address by user operation ID.
  • Rename AlertRow to ConfirmInfoAlertRow.

Open in GitHub Codespaces

Related issues

Fixes: #2673

Manual testing steps

  1. Install example 4337 account snap.
  2. Add ENABLE_CONFIRMATION_REDESIGN=true to .metamaskrc.
  3. Create Mint transaction from test dApp.
  4. Verify Fee paid by row is visible.

Screenshots/Recordings

Before

Screenshot 2024-06-19 at 12 05 37

After

Screenshot 2024-06-19 at 12 04 28

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 changed the title Show paymaster address in redesigned contract interaction feat: show paymaster address in redesigned contract interaction Jun 19, 2024
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Jun 19, 2024
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review June 19, 2024 11:06
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners June 19, 2024 11:06
jpuri
jpuri previously approved these changes Jun 20, 2024
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great 👍

@matthewwalsh0 matthewwalsh0 changed the base branch from feat/redesign-transaction-alerts to develop June 20, 2024 11:17
@matthewwalsh0 matthewwalsh0 dismissed jpuri’s stale review June 20, 2024 11:17

The base branch was changed.

Add missing selector.
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (5c8e1a9) to head (080a644).
Report is 1 commits behind head on develop.

Files Patch % Lines
...onents/confirm/info/shared/transaction-details.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25396      +/-   ##
===========================================
+ Coverage    64.91%   64.93%   +0.01%     
===========================================
  Files         1390     1391       +1     
  Lines        55155    55177      +22     
  Branches     14493    14497       +4     
===========================================
+ Hits         35803    35824      +21     
- Misses       19352    19353       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e06b707]
Page Load Metrics (42 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6414376178
domContentLoaded8201021
load38624253
domInteractive8201021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1015 Bytes (0.01%)
  • common: 162 Bytes (0.00%)

digiwand
digiwand previously approved these changes Jun 21, 2024
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

can reapprove after the merge conflict is resolved

@metamaskbot
Copy link
Collaborator

Builds ready [7b636f3]
Page Load Metrics (126 ± 169 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410479105
domContentLoaded9131011
load401660126352169
domInteractive9131011
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 516 Bytes (0.01%)
  • common: 162 Bytes (0.00%)

jpuri
jpuri previously approved these changes Jun 21, 2024
@matthewwalsh0 matthewwalsh0 merged commit 3777882 into develop Jun 21, 2024
73 of 74 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/paymaster-row branch June 21, 2024 13:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [080a644]
Page Load Metrics (43 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60877384
domContentLoaded8121010
load39654363
domInteractive812910
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 498 Bytes (0.01%)
  • common: 162 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants