-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy changes in re-designed SIWE signature pages #25381
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -67,7 +67,7 @@ const PersonalSignInfo: React.FC = () => { | |||
alertKey="requestFrom" | |||
ownerId={currentConfirmation.id} | |||
label={t('requestFrom')} | |||
tooltip={t('requestFromInfo')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we will want to include these nuances in our upcoming tests #24679
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25381 +/- ##
===========================================
- Coverage 65.38% 65.38% -0.00%
===========================================
Files 1382 1382
Lines 54767 54772 +5
Branches 14368 14371 +3
===========================================
+ Hits 35809 35812 +3
- Misses 18958 18960 +2 ☔ View full report in Codecov by Sentry. |
Description
copy changes in re-designed SIWE signature pages
Related issues
Fixes: #25319
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist