-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show outdated browser warning immediately #25366
Conversation
c6844a5
to
8d96f65
Compare
Builds ready [8d96f65]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25366 +/- ##
========================================
Coverage 70.44% 70.44%
========================================
Files 1274 1274
Lines 44080 44080
Branches 12453 12453
========================================
Hits 31051 31051
Misses 13029 13029 ☔ View full report in Codecov by Sentry. |
8d96f65
to
10745ff
Compare
Builds ready [10745ff]
Page Load Metrics (131 ± 170 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
The outdated browser warning logic has been updated to ensure that it gets shown immediately fot new installations if applicable. We have a timer setup to ensure we don't bother users too often with this warning; it recurs every two days. However, it was initialized to the current date, so new users would not see it for two days.
10745ff
to
122ab47
Compare
Builds ready [122ab47]
Page Load Metrics (131 ± 185 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the warning shows up immediately.
Description
The outdated browser warning logic has been updated to ensure that it gets shown immediately for new installations if applicable.
We have a timer setup to ensure we don't bother users too often with this warning; it recurs every two days. However, it was initialized to the current date, so new users would not see it for two days.
Related issues
N/A
Manual testing steps
Install MetaMask on an outdated browser version, and see that the warning appears.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist