Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show outdated browser warning immediately #25366

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 17, 2024

Description

The outdated browser warning logic has been updated to ensure that it gets shown immediately for new installations if applicable.

We have a timer setup to ensure we don't bother users too often with this warning; it recurs every two days. However, it was initialized to the current date, so new users would not see it for two days.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

Install MetaMask on an outdated browser version, and see that the warning appears.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt marked this pull request as ready for review June 17, 2024 16:21
@Gudahtt Gudahtt requested a review from a team as a code owner June 17, 2024 16:21
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 17, 2024
@Gudahtt Gudahtt force-pushed the immediately-show-outdated-browser-warning branch from c6844a5 to 8d96f65 Compare June 17, 2024 16:31
@metamaskbot
Copy link
Collaborator

Builds ready [8d96f65]
Page Load Metrics (49 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69948073
domContentLoaded9141110
load42644973
domInteractive9141110
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -16 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (fcb4265) to head (122ab47).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25366   +/-   ##
========================================
  Coverage    70.44%   70.44%           
========================================
  Files         1274     1274           
  Lines        44080    44080           
  Branches     12453    12453           
========================================
  Hits         31051    31051           
  Misses       13029    13029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt force-pushed the immediately-show-outdated-browser-warning branch from 8d96f65 to 10745ff Compare June 20, 2024 16:59
@metamaskbot
Copy link
Collaborator

Builds ready [10745ff]
Page Load Metrics (131 ± 170 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62947994
domContentLoaded9201121
load401674131354170
domInteractive9201121
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -16 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

The outdated browser warning logic has been updated to ensure that it
gets shown immediately fot new installations if applicable.

We have a timer setup to ensure we don't bother users too often with
this warning; it recurs every two days. However, it was initialized
to the current date, so new users would not see it for two days.
@Gudahtt Gudahtt force-pushed the immediately-show-outdated-browser-warning branch from 10745ff to 122ab47 Compare June 24, 2024 19:17
@metamaskbot
Copy link
Collaborator

Builds ready [122ab47]
Page Load Metrics (131 ± 185 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6214779199
domContentLoaded812910
load391812131386185
domInteractive812910
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -16 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the warning shows up immediately.

@Gudahtt Gudahtt merged commit edf9957 into develop Jun 26, 2024
73 checks passed
@Gudahtt Gudahtt deleted the immediately-show-outdated-browser-warning branch June 26, 2024 23:40
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants