-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: formatting of deadline in permit signature page #25321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
confirmation-redesign
team-confirmations
Push issues to confirmations team
labels
Jun 14, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25321 +/- ##
===========================================
+ Coverage 65.19% 65.23% +0.04%
===========================================
Files 1405 1406 +1
Lines 55571 55561 -10
Branches 14592 14594 +2
===========================================
+ Hits 36229 36242 +13
+ Misses 19342 19319 -23 ☔ View full report in Codecov by Sentry. |
Builds ready [4e3dc68]
Page Load Metrics (121 ± 165 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/confirmations/components/confirm/info/personal-sign/siwe-sign/siwe-sign.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/personal-sign/siwe-sign/siwe-sign.tsx
Show resolved
Hide resolved
Builds ready [5960490]
Page Load Metrics (47 ± 2 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
previously approved these changes
Jun 20, 2024
…ion into permit_deadline
Builds ready [5ef63d3]
Page Load Metrics (64 ± 10 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
approved these changes
Jun 25, 2024
digiwand
approved these changes
Jun 25, 2024
matthewwalsh0
approved these changes
Jun 25, 2024
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
confirmation-redesign
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve formatting of deadline field in permit signature type.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2642
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist