Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting of deadline in permit signature page #25321

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 14, 2024

Description

Improve formatting of deadline field in permit signature type.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2642

Manual testing steps

  1. Go to test DAPP
  2. Submit permit signature type
  3. Check formatting of deadline field

Screenshots/Recordings

Screenshot 2024-06-14 at 5 56 34 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 14, 2024
@jpuri jpuri requested review from a team as code owners June 14, 2024 12:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.23%. Comparing base (dbdbaf1) to head (5ef63d3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25321      +/-   ##
===========================================
+ Coverage    65.19%   65.23%   +0.04%     
===========================================
  Files         1405     1406       +1     
  Lines        55571    55561      -10     
  Branches     14592    14594       +2     
===========================================
+ Hits         36229    36242      +13     
+ Misses       19342    19319      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4e3dc68]
Page Load Metrics (121 ± 165 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62185792612
domContentLoaded9121010
load381623121345165
domInteractive9111010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.03 KiB (0.01%)
  • common: 134 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5960490]
Page Load Metrics (47 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint599476105
domContentLoaded9241132
load40584752
domInteractive9241132
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.03 KiB (0.02%)
  • common: 118 Bytes (0.00%)

matthewwalsh0
matthewwalsh0 previously approved these changes Jun 20, 2024
@jpuri jpuri requested a review from matthewwalsh0 June 24, 2024 05:36
@metamaskbot
Copy link
Collaborator

Builds ready [5ef63d3]
Page Load Metrics (64 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70144962010
domContentLoaded10351573
load42124642010
domInteractive10351573
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.03 KiB (0.01%)
  • common: 118 Bytes (0.00%)

@jpuri jpuri merged commit 765370f into develop Jun 25, 2024
74 checks passed
@jpuri jpuri deleted the permit_deadline branch June 25, 2024 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants