feat: add rates controller #25314

montelaidev · 2024-06-14T10:41:17Z

Description

This PR adds the RatesController to query for multichain price conversion rates.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/483

Manual testing steps

This PR does not have any UI related changes, it adds new state instead by

Start the extension.
Wait 3 minutes
Download the state log and see that state.metamask.rates is now populated with btc conversion rates.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-14T10:41:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-06-14T14:35:03Z

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.40%. Comparing base (da4b61c) to head (4c2aa8e).
Report is 10 commits behind head on develop.

Files	Patch %	Lines
app/scripts/metamask-controller.js	69.57%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25314      +/-   ##
===========================================
+ Coverage    65.38%   65.40%   +0.01%     
===========================================
  Files         1382     1382              
  Lines        54767    54801      +34     
  Branches     14368    14378      +10     
===========================================
+ Hits         35809    35839      +30     
- Misses       18958    18962       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-14T14:46:22Z

Builds ready [d25cda2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (168 ± 228 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	142	95	18	9
		domContentLoaded	9	25	14	5	2
		load	41	2241	168	476	228
		domInteractive	9	25	14	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 297 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 63 Bytes (0.00%)

ccharly

LGTM.

NOTE: We do not start the controller polling on this PR, we talked about it together and we'll get this setup with incoming PR (like BalancesController one)

metamaskbot · 2024-06-18T08:23:53Z

Builds ready [bc9cc01]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (182 ± 249 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	148	101	18	8
		domContentLoaded	10	26	14	5	2
		load	43	2444	182	519	249
		domInteractive	10	26	14	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 297 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 63 Bytes (0.00%)

k-g-j

The code looks good. I left two suggestions to clarify the test descriptions.

app/scripts/metamask-controller.test.js

metamaskbot · 2024-06-19T01:51:34Z

Builds ready [99ee43c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (162 ± 211 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	364	113	68	33
		domContentLoaded	9	22	12	3	1
		load	42	2069	162	439	211
		domInteractive	9	22	12	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 601 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 63 Bytes (0.00%)

metamaskbot · 2024-06-19T13:51:44Z

Builds ready [a7e9c4c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (52 ± 6 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	118	82	13	6
		domContentLoaded	9	28	12	5	2
		load	41	90	52	13	6
		domInteractive	9	28	12	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 601 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 63 Bytes (0.00%)

k-g-j

Looks good with the updates to the test descriptions!

app/scripts/metamask-controller.js

app/scripts/metamask-controller.test.js

metamaskbot · 2024-06-20T02:02:20Z

Builds ready [0ccb56c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (53 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	107	86	9	5
		domContentLoaded	9	14	11	1	1
		load	40	75	53	9	4
		domInteractive	9	14	11	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 681 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 73 Bytes (0.00%)

app/scripts/metamask-controller.test.js

metamaskbot · 2024-06-20T14:21:02Z

Builds ready [4c2aa8e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	104	83	10	5
		domContentLoaded	9	19	11	3	1
		load	40	65	49	8	4
		domInteractive	9	19	11	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 884 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 73 Bytes (0.00%)

montelaidev added 2 commits June 14, 2024 18:38

feat: add rates controller

49d909c

fix: use default interval

42fca5f

montelaidev self-assigned this Jun 14, 2024

montelaidev added the team-accounts label Jun 14, 2024

montelaidev added 2 commits June 14, 2024 18:42

fix: casing in for initState of RatesController

69ed2be

fix: sentry entries

d25cda2

montelaidev marked this pull request as ready for review June 18, 2024 07:50

montelaidev requested a review from a team as a code owner June 18, 2024 07:50

Merge branch 'develop' into feat/add-rates-controller

bc9cc01

ccharly previously approved these changes Jun 18, 2024

View reviewed changes

fix: add test

2d6ff24

montelaidev dismissed ccharly’s stale review via 2d6ff24 June 18, 2024 08:31

montelaidev added 2 commits June 18, 2024 20:30

Merge branch 'develop' into feat/add-rates-controller

681e334

fix: test

902a0e9

k-g-j previously approved these changes Jun 18, 2024

View reviewed changes

app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved

app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved

Merge branch 'develop' into feat/add-rates-controller

99ee43c

fix: test name

a7e9c4c

montelaidev dismissed k-g-j’s stale review via a7e9c4c June 19, 2024 13:04

montelaidev requested review from ccharly and k-g-j June 19, 2024 13:54

k-g-j previously approved these changes Jun 19, 2024

View reviewed changes

gantunesr reviewed Jun 19, 2024

View reviewed changes

refactor: rename controller

0ccb56c

montelaidev dismissed k-g-j’s stale review via 0ccb56c June 20, 2024 01:33

gantunesr previously approved these changes Jun 20, 2024

View reviewed changes

feat: add start if non EVM account is already selected

2a74356

montelaidev dismissed gantunesr’s stale review via 2a74356 June 20, 2024 13:25

ccharly reviewed Jun 20, 2024

View reviewed changes

app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved

fix: EVM to Evm

4c2aa8e

gantunesr reviewed Jun 20, 2024

View reviewed changes

gantunesr approved these changes Jun 20, 2024

View reviewed changes

ccharly approved these changes Jun 20, 2024

View reviewed changes

ccharly merged commit b279386 into develop Jun 20, 2024
74 checks passed

ccharly deleted the feat/add-rates-controller branch June 20, 2024 14:37

github-actions bot locked and limited conversation to collaborators Jun 20, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add rates controller #25314

feat: add rates controller #25314

montelaidev commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024

codecov bot commented Jun 14, 2024 •

edited

Loading

metamaskbot commented Jun 14, 2024

ccharly left a comment

metamaskbot commented Jun 18, 2024

k-g-j left a comment

metamaskbot commented Jun 19, 2024

metamaskbot commented Jun 19, 2024

k-g-j left a comment

metamaskbot commented Jun 20, 2024

metamaskbot commented Jun 20, 2024

feat: add rates controller #25314

feat: add rates controller #25314

Conversation

montelaidev commented Jun 14, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 14, 2024

codecov bot commented Jun 14, 2024 • edited Loading

Codecov Report

metamaskbot commented Jun 14, 2024

ccharly left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 18, 2024

k-g-j left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 19, 2024

metamaskbot commented Jun 19, 2024

k-g-j left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 20, 2024

metamaskbot commented Jun 20, 2024

montelaidev commented Jun 14, 2024 •

edited

Loading

codecov bot commented Jun 14, 2024 •

edited

Loading