Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap+send e2e tests #25275

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: swap+send e2e tests #25275

merged 1 commit into from
Jun 12, 2024

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented Jun 12, 2024

Description

418ecfc was moved from #25230 into this separate PR.

@micaelae wrote:

the main change in the commit is to update the test ganache network. we were configuring the tests without EIP-1559 support before. and as a result, gas fees in the Send page were calculated using the response of https://gas.api.cx.metamask.io/networks/1/gasPrices. afaik the response was getting mocked to a constant value before so the tests succeeded reliably.
after your change, the response of that endpoint became variable. which made me look into why the gas fees were excessively high within the test in the first place
since the Swap+Send experience only runs in networks that support EIP-1559, I updated the test network. as a result the tests now use the suggestedGasFees endpoint mock, which also corrected the gas calculation test bug

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dbrans dbrans marked this pull request as ready for review June 12, 2024 21:32
@dbrans dbrans requested a review from a team as a code owner June 12, 2024 21:32
@dbrans dbrans merged commit dda8d96 into develop Jun 12, 2024
77 of 79 checks passed
@dbrans dbrans deleted the dbrans/swap-send-e2e-fix branch June 12, 2024 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [aa67f9d]
Page Load Metrics (48 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6310880115
domContentLoaded9211121
load41694863
domInteractive9211121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jun 20, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants