Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Moonbeam & Moonriver Logos #25267

Conversation

albertov19
Copy link

@albertov19 albertov19 commented Jun 12, 2024

Description

Updates the Moonbeam/Moonriver logos following the new brand guidelines

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

I've built Metamask locally to confirm logo dimensions

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@albertov19 albertov19 requested a review from a team as a code owner June 12, 2024 17:50
Copy link
Contributor

github-actions bot commented Jun 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertov19
Copy link
Author

Woud be great to also update token logos for these. Thanks!

GLMR_Square
MOVR_Square

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 12, 2024
@albertov19
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Aug 11, 2024
@albertov19
Copy link
Author

Any updates here ? Simple PR to update logos

@github-actions github-actions bot removed the stale issues and PRs marked as stale label Aug 11, 2024
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 26, 2024
@sahar-fehri sahar-fehri changed the title Update Moonbeam & Moonriver Logos fix: Update Moonbeam & Moonriver Logos Aug 26, 2024
@sahar-fehri
Copy link
Contributor

sahar-fehri commented Aug 26, 2024

Woud be great to also update token logos for these. Thanks!

GLMR_Square MOVR_Square

Hi @albertov19 ! where can i find the svg for these token logos? 🙏

@albertov19
Copy link
Author

Woud be great to also update token logos for these. Thanks!
GLMR_Square MOVR_Square

Hi @albertov19 ! where can i find the svg for these token logos? 🙏

Hey, thanks for getting back to me.

You can check Moonbeam guidelines.

For example, Moonbeam logo and Moonriver logo

These versions are round tho, so that is why I created and uploaded the square versions for you 😄

@sahar-fehri
Copy link
Contributor

Hey @albertov19 !
I have created this PR based on your changes that also updates the logos: #26677 ; could you have a look and approve it if it looks good? 🙏

@albertov19
Copy link
Author

Hey @albertov19 ! I have created this PR based on your changes that also updates the logos: #26677 ; could you have a look and approve it if it looks good? 🙏

Looks great! Thanks for working on this

sahar-fehri added a commit that referenced this pull request Aug 27, 2024
## **Description**

This PR updates the network and token logos for moonbeam and moonriver
networks.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26677?quickstart=1)

## **Related issues**

Fixes:
Related: #25267

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/06413f29-64e7-4927-9bad-00677424a7a2


### **After**


https://github.com/user-attachments/assets/a3100c81-0988-4709-8c77-b12003b06643


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sahar-fehri
Copy link
Contributor

Closing this one after merging #26677

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants