-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account overview for bip122:* account types #25200
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1fcb16f
to
76a3079
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
1e21571
to
b658a26
Compare
7f63f00
to
afa35f4
Compare
5b14edc
to
a80e5af
Compare
…troller's messenger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left two minor comments
Co-authored-by: Gustavo Antunes <[email protected]>
Builds ready [ec27cb7]
Page Load Metrics (443 ± 364 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This adds a new
AccountOverview
component for the BIP122 account types.Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/423
Manual testing steps
yarn start:flask
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist