Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account overview for bip122:* account types #25200

Merged
merged 54 commits into from
Jun 28, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jun 11, 2024

Description

This adds a new AccountOverview component for the BIP122 account types.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/423

Manual testing steps

  1. Start your extension: yarn start:flask
  2. Run the bitcoin Snap + dapp: https://github.com/MetaMask/bitcoin
  3. Go to: http://localhost:8000/
  4. Install the Snap and create an account
  5. You should see it in the account list and you should be able to see the overview of your account

Screenshots/Recordings

Before

After

Screenshot 2024-06-27 at 16 03 16
Screenshot 2024-06-27 at 16 03 21
Screenshot 2024-06-27 at 16 03 26

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly force-pushed the feature/btc-account-overview branch from 1fcb16f to 76a3079 Compare June 11, 2024 08:53
Copy link

socket-security bot commented Jun 11, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@ccharly ccharly force-pushed the feature/btc-account-overview branch 4 times, most recently from 1e21571 to b658a26 Compare June 12, 2024 14:17
@ccharly ccharly self-assigned this Jun 12, 2024
@ccharly ccharly force-pushed the feature/btc-account-overview branch 3 times, most recently from 7f63f00 to afa35f4 Compare June 14, 2024 11:42
@ccharly ccharly force-pushed the feature/btc-account-overview branch 2 times, most recently from 5b14edc to a80e5af Compare June 26, 2024 08:33
@ccharly ccharly mentioned this pull request Jun 26, 2024
7 tasks
ui/selectors/multichain.ts Show resolved Hide resolved
ui/selectors/multichain.ts Show resolved Hide resolved
shared/constants/network.ts Show resolved Hide resolved
shared/lib/multichain.ts Outdated Show resolved Hide resolved
shared/lib/multichain.test.ts Outdated Show resolved Hide resolved
ui/components/app/asset-list/asset-list.js Show resolved Hide resolved
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left two minor comments

@metamaskbot
Copy link
Collaborator

Builds ready [ec27cb7]
Page Load Metrics (443 ± 364 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint643671237938
domContentLoaded97923178
load422218443758364
domInteractive97923178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 388 Bytes (0.01%)
  • ui: 4.78 KiB (0.07%)
  • common: 657 Bytes (0.01%)

@montelaidev montelaidev merged commit b37e39d into develop Jun 28, 2024
70 checks passed
@montelaidev montelaidev deleted the feature/btc-account-overview branch June 28, 2024 06:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants