Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simulations on signature pages should be displayed only if preference is enabled #25186

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 10, 2024

Description

PR to address discussion here: #24862 (comment)

Simulations on signature pages should be displayed only if preference is enabled

Related issues

Fixes:

Manual testing steps

  1. Enable simulations and re-designs for signatures
  2. Go to test DAPP and open permit signature
  3. Simulations should be visible

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 10, 2024
@jpuri jpuri requested a review from a team as a code owner June 10, 2024 17:53
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Jun 11, 2024
ui/pages/confirmations/selectors/preferences.ts Outdated Show resolved Hide resolved
@jpuri jpuri force-pushed the fix_simulation_display branch from 18e0020 to 1c6b783 Compare June 12, 2024 10:11
Base automatically changed from permit_signature_simulation_info to develop June 12, 2024 12:07
@jpuri jpuri dismissed matthewwalsh0’s stale review June 12, 2024 12:07

The base branch was changed.

@jpuri jpuri requested a review from a team as a code owner June 12, 2024 12:07
@jpuri jpuri force-pushed the fix_simulation_display branch from 1c6b783 to 899afae Compare June 12, 2024 12:16
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (696cf1d) to head (3f0e61f).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25186   +/-   ##
========================================
  Coverage    65.56%   65.56%           
========================================
  Files         1372     1373    +1     
  Lines        54486    54490    +4     
  Branches     14265    14265           
========================================
+ Hits         35720    35724    +4     
  Misses       18766    18766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [899afae]
Page Load Metrics (58 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64284934522
domContentLoaded98915178
load40189583115
domInteractive98915178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 835 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri requested review from digiwand and matthewwalsh0 June 12, 2024 13:45
digiwand
digiwand previously approved these changes Jun 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f4a6e8f]
Page Load Metrics (50 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701018394
domContentLoaded8151121
load42685073
domInteractive8151121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 847 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri dismissed stale reviews from pedronfigueiredo and digiwand via 3f0e61f June 12, 2024 16:56
@metamaskbot
Copy link
Collaborator

Builds ready [3f0e61f]
Page Load Metrics (54 ± 12 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60203883216
domContentLoaded98414168
load40126542512
domInteractive98414168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 847 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 59a805a into develop Jun 13, 2024
72 checks passed
@jpuri jpuri deleted the fix_simulation_display branch June 13, 2024 05:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants