-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: addressing feedbacks in typed sign alerts #25163
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…k-extension into typed_sign_alerts_fixes
@@ -202,7 +202,7 @@ describe('ConfirmFooter', () => { | |||
}; | |||
it('renders the review alerts button when there are unconfirmed alerts', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it the case to update the description to something like: renders the confirm button when there is one unconfirmed alert
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25163 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1362 1362
Lines 54189 54189
Branches 14112 14112
========================================
Hits 35572 35572
Misses 18617 18617 ☔ View full report in Codecov by Sentry. |
Builds ready [ebe2a8f]
Page Load Metrics (161 ± 221 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Addressing feedbacks in alerts integrated to typed sign data pages.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2615
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist