Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve all known swap+send bugs #25100

Merged
merged 24 commits into from
Jun 7, 2024
Merged

fix: resolve all known swap+send bugs #25100

merged 24 commits into from
Jun 7, 2024

Conversation

BZahory
Copy link
Contributor

@BZahory BZahory commented Jun 6, 2024

Description

A number of minor bugs have been discovered during the official QA process of Swap+Send; this PR aims to resolve all of them without regression.

Open in GitHub Codespaces

Related issues

METABRIDGE-843

Fixes:

Manual testing steps

  1. Test all issues with a send-swap label
  2. Ensure they are no longer present
  3. Ensure Swap+Send continues to work as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested a review from a team as a code owner June 6, 2024 13:52
Copy link
Contributor

github-actions bot commented Jun 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ejwessel
ejwessel previously approved these changes Jun 7, 2024
ejwessel
ejwessel previously approved these changes Jun 7, 2024
@micaelae micaelae mentioned this pull request Jun 7, 2024
7 tasks
Comment on lines 89 to 92
setTimeout(() => {
this.unitInput.scrollLeft = this.unitInput.scrollWidth;
}, 0);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

seeing some odd behavior when I enter a long number like 0.12414314125153525326236. only the ending numbers are displayed on unfocus. also happens when I hit Max and my balance has a lot of trailing numbers

Screenshot 2024-06-07 at 3 35 49 PM

@micaelae micaelae added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 40 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (ddf0e93) to head (d6536aa).

Files Patch % Lines
ui/ducks/send/send.js 53.97% 29 Missing ⚠️
...r-amount/asset-picker-modal/asset-picker-modal.tsx 57.69% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25100   +/-   ##
========================================
  Coverage    65.64%   65.64%           
========================================
  Files         1362     1362           
  Lines        54151    54189   +38     
  Branches     14074    14112   +38     
========================================
+ Hits         35546    35572   +26     
- Misses       18605    18617   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BZahory BZahory merged commit 957fab3 into develop Jun 7, 2024
76 of 77 checks passed
@BZahory BZahory deleted the mb843/qa-fixes branch June 7, 2024 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d6536aa]
Page Load Metrics (118 ± 157 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60987684
domContentLoaded8191021
load381542118327157
domInteractive8191021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 370 Bytes (0.01%)
  • common: 999 Bytes (0.02%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants