fix: Avoid to send the snap notification id to the notifications server #25099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| useState<MarkAsReadNotificationsParam>([]); | ||
|
|
||
| useEffect(() => { | ||
| const handleOnClick = () => { |
There was a problem hiding this comment.
Nice, we did not need an effect! ❤️
| trackEvent({ | ||
| category: MetaMetricsEventCategory.NotificationInteraction, | ||
| event: MetaMetricsEventName.MarkAllNotificationsRead, | ||
| }); | ||
|
|
||
| // Mark all metamask notifications as read | ||
| markNotificationAsRead(notificationReadArray); | ||
| markNotificationAsRead(notificationsRead); |
There was a problem hiding this comment.
I got really confused since we were filtering out snap notifications.
But yes this method (as the comment above mentions) is only for wallet notifications, so we can filter out these notifications.
Prithpal-Sooriya
approved these changes
Jun 6, 2024
dovydas55
approved these changes
Jun 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25099 +/- ##
===========================================
- Coverage 65.66% 65.65% -0.01%
===========================================
Files 1359 1359
Lines 54014 54012 -2
Branches 14015 14017 +2
===========================================
- Hits 35464 35459 -5
- Misses 18550 18553 +3 ☔ View full report in Codecov by Sentry. |
Builds ready [b8622ca]
Page Load Metrics (47 ± 3 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug related to the "Mark all notifications as read" button. The button is responsible, when clicked, for performing the actions to mark a notification as read. In the case of on-chain notifications, this state needs to be saved via API on the notification server. The PR prevents the IDs of SNAP notifications from being sent to the server, as their read/unread state is managed differently.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist