Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cherry-pick): iframe injection in MV3 (#25051) #25056

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix(cherry-pick): iframe injection in MV3 (#25051) #25056

merged 1 commit into from
Jun 5, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 5, 2024

Cherry picks 98385ff (#25051) to Version-v11.16.6

@FrederikBolding @danjm
fix: iframe injection in MV3 (#25051)
0e3b4ee 
## **Description**

Fixes injection into iframes in the MV3 build by enabling `allFrames`.
This is also currently enabled in MV2:
https://github.com/MetaMask/metamask-extension/blob/13bd82914d1ac2c584fb799e6eee9b90fe889fe2/app/manifest/v2/_base.json#L42

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25051?quickstart=1)

## **Manual testing steps**

1. Go to https://jup.ag/
2. Try connecting with MetaMask, this will use Solflare snap
3. You should be able to fully connect to the site
@danjm danjm requested a review from a team as a code owner June 5, 2024 10:28
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 5, 2024
@danjm danjm merged commit d3895c2 into Version-v11.16.6 Jun 5, 2024
70 of 71 checks passed
@danjm danjm deleted the cherry-pick-98385ff-v11.16.6 branch June 5, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@metamaskbot metamaskbot added the release-11.16.6 Issue or pull request that will be included in release 11.16.6 label Jun 5, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.16.6 on PR, as PR was cherry-picked in branch 11.16.6.

@metamaskbot
Copy link
Collaborator

Builds ready [0e3b4ee]
Page Load Metrics (838 ± 575 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682031193617
domContentLoaded107130189
load4531578381198575
domInteractive107130189

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.6 Issue or pull request that will be included in release 11.16.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjm @metamaskbot @FrederikBolding