feat: Support various redesign signatures in ConfirmPage Storybook #25054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
previously approved these changes
Jun 5, 2024
Builds ready [9b804ae]
Page Load Metrics (368 ± 327 ms)
Bundle size diffs
|
Builds ready [9b804ae]
Page Load Metrics (368 ± 327 ms)
Bundle size diffs
|
Builds ready [9b804ae]
Page Load Metrics (368 ± 327 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25054 +/- ##
========================================
Coverage 65.61% 65.61%
========================================
Files 1365 1365
Lines 54224 54224
Branches 14180 14180
========================================
Hits 35576 35576
Misses 18648 18648 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
previously approved these changes
Jun 6, 2024
| const ConfirmPageStory = { | ||
| title: 'Pages/Confirm/ConfirmPage', | ||
| decorators: [(story) => <Provider store={store}>{story()}</Provider>], | ||
| decorators: [(story) => <div style={{ height: '600px' }}>{story()}</div>], |
There was a problem hiding this comment.
Should we also force the width so it matches the standard MetaMask popup?
There was a problem hiding this comment.
Good question. As you might have noticed, the height resembles our popup height. I added this to view the scrollToBottom feature on some of the signature pages without needing to hardcode or add a control for this.
I left out the width so that we could easily test various widths. These decisions were subjective. Open to other suggestions
There was a problem hiding this comment.
Could we still support re-sizing to test wrapping etc, but default to the standard width?
jpuri
previously approved these changes
Jun 6, 2024
pedronfigueiredo
previously approved these changes
Jun 6, 2024
digiwand
dismissed stale reviews from pedronfigueiredo, jpuri, and matthewwalsh0
via
8510dfc
pedronfigueiredo
approved these changes
Jun 6, 2024
matthewwalsh0
approved these changes
Jun 11, 2024
Builds ready [1076e3b]
Page Load Metrics (49 ± 4 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for various redesign signatures for the ConfirmPage storybook.
Related issues
Fixes: #25052
Manual testing steps
yarn storybookScreenshots/Recordings
Before
After
CleanShot.2024-06-05.at.18.35.43-converted.mp4
higher quality of above:
https://github.com/MetaMask/metamask-extension/assets/20778143/342a6182-c443-4bd9-907a-3441b4b9eb81
Pre-merge author checklist
Pre-merge reviewer checklist