Version-v11.6.6: patch @metamask/selected-network-controller 12.0.1 #25046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jiexi
changed the title
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #25046 +/- ##
==========================================
- Coverage 67.33% 67.33% -0.00%
==========================================
Files 1266 1266
Lines 49621 49626 +5
Branches 12890 12895 +5
==========================================
+ Hits 33409 33411 +2
- Misses 16212 16215 +3 ☔ View full report in Codecov by Sentry. |
danjm
force-pushed
the
jl/patch-Version-v11-16.6-selected-network-controller
branch
from
f694565 to
d70ac20
Compare
A selector used in the new multichain UI was assuming that all sites were present in the `domains` state. But only connected sites are expected to be present there. A fallback has been added to ensure that the globally selected chain is used as the "selected chain" for unconnected sites in this UI. This matches what the inpage provider would show to these sites as well.
Builds ready [f29bf5d]
Page Load Metrics (143 ± 179 ms)
|
metamaskbot
added
the
release-11.16.7
|
No release label on PR. Adding release label release-11.16.7 on PR, as PR was added to branch 11.16.7 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for v11.6.6 that patches @metamask/selected-network-controller 12.0.1 to include a check for if the useRequestQueue flag is set before setting the networkClientId for a domain on permission controller state change additions
SelectedNetworkControllerpermission state change handler core#4368