You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates Mumbai and linea goerli test networks.
Users should see a deprecation warning when switching to those networks.
Linea goerli is removed from the default network list.
Click on network selector, You should not see Linea testnet in the list.
Add Mumbai network to metamask
You should see deprecation warning
Screenshots/Recordings
Before
Linea goerli appears in the list of default networks
After
In this video initially the user is on Linea goerli (i am on develop branch), the user makes a few transactions on linea goerli,
then i switch to this branch so the migration runs, and notice that the user has switeched to linea-sepolia.
Linea goerli is removed from the default networks tab.
When the user adds linea-goerli using chainlist, he sees the deprecation warning and his transactions.
deprecation1.mov
This short video shows the deprecation warning when we switch to Mumbai network
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates Mumbai and linea goerli test networks.
Users should see a deprecation warning when switching to those networks.
Linea goerli is removed from the default network list.
Related issues
ticket: https://consensyssoftware.atlassian.net/browse/MMASSETS-183
patch for controller-utils: https://github.com/MetaMask/metamask-extension/pull/23727/files
Manual testing steps
Screenshots/Recordings
Before
Linea goerli appears in the list of default networks
After
In this video initially the user is on Linea goerli (i am on develop branch), the user makes a few transactions on linea goerli,
then i switch to this branch so the migration runs, and notice that the user has switeched to linea-sepolia.
Linea goerli is removed from the default networks tab.
When the user adds linea-goerli using chainlist, he sees the deprecation warning and his transactions.
deprecation1.mov
This short video shows the deprecation warning when we switch to Mumbai network
Screen.Recording.2024-03-26.at.16.12.46.mov
Pre-merge author checklist
Pre-merge reviewer checklist