Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecating more networks #24994

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 3, 2024

Description

Deprecates Mumbai and linea goerli test networks.
Users should see a deprecation warning when switching to those networks.
Linea goerli is removed from the default network list.

Open in GitHub Codespaces

Related issues

ticket: https://consensyssoftware.atlassian.net/browse/MMASSETS-183
patch for controller-utils: https://github.com/MetaMask/metamask-extension/pull/23727/files

Manual testing steps

  1. Go to home page
  2. Click on network selector, You should not see Linea testnet in the list.
  3. Add Mumbai network to metamask
  4. You should see deprecation warning

Screenshots/Recordings

Before

Linea goerli appears in the list of default networks

Screenshot 2024-03-26 at 16 17 41

After

In this video initially the user is on Linea goerli (i am on develop branch), the user makes a few transactions on linea goerli,
then i switch to this branch so the migration runs, and notice that the user has switeched to linea-sepolia.
Linea goerli is removed from the default networks tab.
When the user adds linea-goerli using chainlist, he sees the deprecation warning and his transactions.

deprecation1.mov

This short video shows the deprecation warning when we switch to Mumbai network

Screen.Recording.2024-03-26.at.16.12.46.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested review from a team as code owners June 3, 2024 10:52
Copy link
Contributor

github-actions bot commented Jun 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 3, 2024
@salimtb salimtb requested a review from sahar-fehri June 3, 2024 10:54
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.52%. Comparing base (f9d9bde) to head (089e0c1).
Report is 14 commits behind head on develop.

Files Patch % Lines
...tions/confirmation/templates/add-ethereum-chain.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24994      +/-   ##
===========================================
+ Coverage    65.45%   65.52%   +0.07%     
===========================================
  Files         1352     1353       +1     
  Lines        53971    53995      +24     
  Branches     14004    14024      +20     
===========================================
+ Hits         35326    35379      +53     
+ Misses       18645    18616      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2f60905]
Page Load Metrics (116 ± 129 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711048795
domContentLoaded9201121
load471288116269129
domInteractive9201121

@salimtb salimtb added the team-confirmations Push issues to confirmations team label Jun 3, 2024
@salimtb salimtb force-pushed the fix/add-migration-for-linea-goerli-2 branch 3 times, most recently from 657856a to 9a58577 Compare June 5, 2024 14:18
@salimtb salimtb force-pushed the fix/add-migration-for-linea-goerli-2 branch from 9a58577 to 089e0c1 Compare June 6, 2024 08:26
@metamaskbot
Copy link
Collaborator

Builds ready [089e0c1]
Page Load Metrics (48 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631038094
domContentLoaded8171021
load40604852
domInteractive8171021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.04 KiB (0.06%)
  • ui: -356 Bytes (-0.01%)
  • common: -302 Bytes (-0.00%)

@salimtb salimtb requested a review from sahar-fehri June 6, 2024 10:04
@salimtb salimtb merged commit c9e944d into develop Jun 7, 2024
77 checks passed
@salimtb salimtb deleted the fix/add-migration-for-linea-goerli-2 branch June 7, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants