-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test #24926
test: fix flaky test #24926
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, this shouldn't be navigating
anyway, even if we fix the larger Sentry problem
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24926 +/- ##
========================================
Coverage 65.85% 65.85%
========================================
Files 1363 1363
Lines 54254 54254
Branches 14114 14114
========================================
Hits 35725 35725
Misses 18529 18529 ☔ View full report in Codecov by Sentry. |
Builds ready [09b74f2]
Page Load Metrics (204 ± 271 ms)
Bundle size diffs
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
On very slow machines the "Import flow @no-mmi Import wallet using Secret Recovery Phrase" test can fail with an error, as seen here: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/83747/workflows/b71850d1-d6fb-484d-8666-1ed6b4222308/jobs/3002940/parallel-runs/1?invite=true#step-104-1600
This change works around the bug by avoiding the extraneous call to
driver.navigate()
that was sometimes triggering a call to out to sentry (that would be then be immediately cancelled, which causes the exception to be raised).This doesn't fix the root of the problem (if there is one), but it works around the issue in a way that won't affect any or get in the way of a future "fix" (I don't think this is really a bug, but just an issue with our tests).