Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test #24926

Merged
merged 1 commit into from
May 31, 2024
Merged

test: fix flaky test #24926

merged 1 commit into from
May 31, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented May 31, 2024

On very slow machines the "Import flow @no-mmi Import wallet using Secret Recovery Phrase" test can fail with an error, as seen here: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/83747/workflows/b71850d1-d6fb-484d-8666-1ed6b4222308/jobs/3002940/parallel-runs/1?invite=true#step-104-1600

This change works around the bug by avoiding the extraneous call to driver.navigate() that was sometimes triggering a call to out to sentry (that would be then be immediately cancelled, which causes the exception to be raised).

This doesn't fix the root of the problem (if there is one), but it works around the issue in a way that won't affect any or get in the way of a future "fix" (I don't think this is really a bug, but just an issue with our tests).

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@HowardBraham HowardBraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, this shouldn't be navigating anyway, even if we fix the larger Sentry problem

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.85%. Comparing base (a1718d9) to head (09b74f2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24926   +/-   ##
========================================
  Coverage    65.85%   65.85%           
========================================
  Files         1363     1363           
  Lines        54254    54254           
  Branches     14114    14114           
========================================
  Hits         35725    35725           
  Misses       18529    18529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [09b74f2]
Page Load Metrics (204 ± 271 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410786126
domContentLoaded9321363
load612660204564271
domInteractive9321363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review May 31, 2024 01:27
@davidmurdoch davidmurdoch requested a review from a team as a code owner May 31, 2024 01:27
@davidmurdoch davidmurdoch merged commit a43fc9e into develop May 31, 2024
76 of 77 checks passed
@davidmurdoch davidmurdoch deleted the fix-flaky-sentry branch May 31, 2024 01:27
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels May 31, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

@HowardBraham HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-11.16.6 Issue or pull request that will be included in release 11.16.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants