fix: Ensure network request to ledger bridge is not made during onboarding

[danjm]

Description

Currently during onboarding, a network request is made to our github.io ledger bridge page. We want to prevent this until later.

The PR ensures that the requests made as a result of establishing a connection with ledger when submitting a password or restoring a vault only happen if the user is already onboarded. Then, when the user goes to the hardware connection page, the communication with the ledger bridge will begin.

Because setting the ledger transport type no longer happens during onboarding, we now make sure it happens during hardware wallet connection

Manual testing steps

1. Install and onboarding. There should be no network requests to the github pages ledger bridge during or immediately after onboarding
2. Go to the hardware wallet connect screen and select ledger. There will now be a network request to the ledger bridge
3. You should be able to successfully connect your ledger hardware wallet

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.72%. Comparing base (038dbbb) to head (fd79f50).
Report is 19 commits behind head on develop.

Files	Patch %	Lines
app/scripts/metamask-controller.js	66.67%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24890      +/-   ##
===========================================
- Coverage    65.76%   65.72%   -0.03%     
===========================================
  Files         1366     1366              
  Lines        54275    54282       +7     
  Branches     14105    14109       +4     
===========================================
- Hits         35690    35676      -14     
- Misses       18585    18606      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[darkwing]

With this I was able to add a Ledger after onboarding. WFM!

[metamaskbot]

Builds ready [fd79f50]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (945 ± 576 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	166	96	27	13
		domContentLoaded	9	17	12	2	1
		load	60	2885	945	1199	576
		domInteractive	9	17	11	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 232 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[danjm]

I am working on some tests for this. The e2e ones are tricky because the network requests happen in an iframe within the offscreen document. I put my work on the tests on pause, but will prioritize as soon as the MV3 RC is created (so tomorrow some time)

[metamaskbot]

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.