fix(24732): fix error when sending txn from dapp and editing the gas

[DDDDDanica]

Description

There is a racing condition captured in MV3 build. When sending transaction from dapp directly, if user chooses to edit the gas fee, and when suggestedGasFees request is processing slow, gasFeeEstimates could be undefined within hook useCustomTimeEstimate.js. The fix is to add a condition for accessing this object before forwarding to UI.

Related issues

Fixes: #24732

Manual testing steps

1. Build in MV3
2. Trigger a txn from dapp
3. Open network panel, and trigger edit gas button before suggestedGasFees is finished fetching
4. You should see the network edition panel

Screenshots/Recordings

Before

by @seaona

network-api-reqs.mp4

After

Pre-merge author checklist

mv3-gas-edition.mov

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [a4da8b3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (295 ± 322 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	116	89	15	7
		domContentLoaded	9	34	12	5	3
		load	54	2420	295	670	322
		domInteractive	9	34	12	5	3

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 24 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[pedronfigueiredo]

does this and the next condition not need gasFeeEstimates && as well? Alternatively, perhaps gasFeeEstimates?. could work on all of them

[DDDDDanica]

good suggestion ! added optional chaining in the equation

[metamaskbot]

Builds ready [2eb1e66]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (695 ± 515 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	241	106	38	18
		domContentLoaded	8	55	17	13	6
		load	52	3015	695	1073	515
		domInteractive	8	55	17	13	6

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 177 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.67%. Comparing base (7eb2f2b) to head (81e245a).
Report is 11 commits behind head on develop.

Files	Patch %	Lines
...fee-popover/edit-gas-item/useCustomTimeEstimate.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24810      +/-   ##
===========================================
- Coverage    65.67%   65.67%   -0.00%     
===========================================
  Files         1360     1360              
  Lines        54105    54104       -1     
  Branches     14066    14065       -1     
===========================================
- Hits         35533    35532       -1     
  Misses       18572    18572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [81e245a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (414 ± 389 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	123	88	17	8
		domContentLoaded	9	47	14	11	5
		load	52	2393	414	811	389
		domInteractive	9	47	14	11	5

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 137 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.