Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test for Wallet Created Events @no-mmi are not sent when onboarding user who chooses to opt out metrics #24789

Merged
merged 2 commits into from
May 27, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented May 27, 2024

Description

The problem seems to be that sometimes Linux is not able to find the sound card (for unknown reasons). This happens specifically to any of the onboarding tests that go to the video screen.

Context: other Linux users reporting this error ALSA lib confmisc.c:855:(parse_card) cannot find card '0' can be found here.

ALSA lib confmisc.c:855:(parse_card) cannot find card '0'
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_card_inum returned error: No such file or directory
ALSA lib confmisc.c:422:(snd_func_concat) error evaluating strings
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1334:(snd_func_refer) error evaluating name
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5701:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2664:(snd_pcm_open_noupdate) Unknown PCM default

The solution is to not render the video Box component if we are in test mode.

Circleci failures: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/82995/workflows/51b18b16-f786-4ee8-96d0-9c751af6fa17/jobs/2965494/artifacts

Open in GitHub Codespaces

Related issues

Fixes: #24602

Manual testing steps

  1. Check ci run

Screenshots/Recordings

Artifacts from ci: test fails at the screen with the video

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona self-assigned this May 27, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona marked this pull request as ready for review May 27, 2024 14:56
@seaona seaona requested a review from a team as a code owner May 27, 2024 14:56
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, nice find

@DDDDDanica
Copy link
Contributor

This is a very interesting found!

@seaona seaona merged commit 51ef3cb into develop May 27, 2024
88 of 89 checks passed
@seaona seaona deleted the flaky-fix-wallet-onboarding branch May 27, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
@metamaskbot metamaskbot added release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels Jun 4, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flaky tests release-11.16.6 Issue or pull request that will be included in release 11.16.6 team-extension-platform
Projects
Archived in project
4 participants