feat(mmi): start implementing mmi ofa feature #24749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24749 +/- ##
=========================================
Coverage 65.73% 65.73%
=========================================
Files 1369 1363 -6
Lines 54417 54274 -143
Branches 14161 14111 -50
=========================================
- Hits 35766 35674 -92
+ Misses 18651 18600 -51 ☔ View full report in Codecov by Sentry. |
Builds ready [0dd3ba7]
Page Load Metrics (206 ± 275 ms)
Bundle size diffs
|
albertolive
changed the title
Builds ready [aeda3db]
Page Load Metrics (141 ± 159 ms)
Bundle size diffs
|
Builds ready [f5faf08]
Page Load Metrics (51 ± 6 ms)
Bundle size diffs
|
Builds ready [84521d5]
Page Load Metrics (137 ± 182 ms)
Bundle size diffs
|
DDDDDanica
previously approved these changes
Jun 18, 2024
zone-live
previously approved these changes
Jun 18, 2024
| @@ -836,6 +838,13 @@ export default class ConfirmTransactionBase extends Component { | |||
| txData.metadata.note = noteText; | |||
| } | |||
|
|
|||
| if ( | |||
| smartTransactionsOptInStatus && | |||
There was a problem hiding this comment.
If we're trying to detect if this is a smart transaction, should we be using the getSmartTransactionsEnabled selector as it also checks the feature flag so if the service is live?
There was a problem hiding this comment.
Thanks for the quick response @matthewwalsh0 ! I appreciate it; I didn't know that it existed. I'll do the changes
| smartTransactionsOptInStatus && | ||
| currentChainSupportsSmartTransactions | ||
| ) { | ||
| txData.origin += '#smartTransaction'; |
There was a problem hiding this comment.
Why are we mutating an existing property in this instance as opposed to using a new property for example?
Is the origin not traditionally a host name so won't this break that assumption and potentially impact other UX?
There was a problem hiding this comment.
@matthewwalsh0, we are using the origin because we don’t want to add any new properties for now, as it would impact our Ethereum custodian API.
There was a problem hiding this comment.
As long as you're sure it won't break any of the UI, fair enough given this branch is specific to MMI.
Builds ready [cf59707]
Page Load Metrics (49 ± 6 ms)
Bundle size diffs
|
zone-live
approved these changes
Jun 19, 2024
matthewwalsh0
approved these changes
Jun 19, 2024
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Order Flow Auction (OFA) has launched on MetaMask retail side, MMI is exploring ways to add support of OFA on the MMI extension and for their user base. The architecture will be slightly different as MMI has the custodian in between the transaction flow where the signing is happening. In general custodians do the signing and broadcasting themselves but we have introduced an updated API on our side (namely ECA3) which allows custodians to send back signed raw transactions which then is broadcasted by MMI through a backend service (unlike how MetaMask works).
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMI-5059
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist