fix: Improve flakiness of await driver.findElements in 'importing multiple tokens from search' test

[danjm]

Description

This improves on a flaky test that I noticed while working to get mv3 tests to pass. I think it is flaky on mv2 as well. The bug is not visually reproducible manually, but I saw it fail twice on CI.

The test clicks "import-tokens-modal-import-button", then waits for for the loading spinner to be not present, and then finds tokens in the list. It finds the token list as a group and then checks that the expected number are present.

The problem is that the list is not fully populated at the exact same time that the loading spinner is removed.

The fix is to rewrite the test so that it waits for the expected number of tokens to be rendered (instead of assuming the token list is immediately in the fully populated state).

Manual testing steps

This test should continue to pass on all e2e jobs

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (c586d33) to head (f239c7b).
Report is 6 commits behind head on develop.

❗ Current head f239c7b differs from pull request most recent head b4ecf88

Please upload reports for the commit b4ecf88 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24694   +/-   ##
========================================
  Coverage    67.41%   67.41%           
========================================
  Files         1288     1288           
  Lines        50233    50233           
  Branches     13014    13014           
========================================
  Hits         33863    33863           
  Misses       16370    16370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [f239c7b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (953 ± 522 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	161	94	24	12
		domContentLoaded	9	55	15	10	5
		load	48	2554	953	1088	522
		domInteractive	9	55	15	10	5

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[seaona]

nice!

[metamaskbot]

Builds ready [b4ecf88]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1008 ± 559 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	123	90	18	9
		domContentLoaded	9	37	14	8	4
		load	55	3058	1008	1165	559
		domInteractive	9	37	14	8	4

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.