-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update help center URLs #24286
fix: Update help center URLs #24286
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA. |
Also find some instance can be updated:
BTW is it needed to update links in |
Mentions of
|
Hi there @DDDDDanica and @legobeat! I've added additional links, as mentioned. Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions. Let me know whether you might need anything else from my end in order to get this live as soon as possible, as currently, a lot of these links are broken. |
LGTM ! Let me know when you have the test fixed. |
## **Description** The MetaMask help center has migrated from using Zendesk to Docusaurus. The old Zendesk URL is no longer in use, and the support.metamask.io domain should be used instead. Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions. Also see MetaMask/metamask-extension#24286. ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [*] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [*] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
## **Description** The MetaMask help center has migrated from using Zendesk to Docusaurus. The old Zendesk URL is no longer in use, and the support.metamask.io domain should be used instead. Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions. Also see MetaMask/metamask-extension#24286. ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [*] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [*] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Just for the record, we are still using the old URL in some files like: builds.yml
68: - SUPPORT_LINK: https://metamask-flask.zendesk.com/hc
69: - SUPPORT_REQUEST_LINK: https://metamask-flask.zendesk.com/hc/en-us/requests/new |
@wtzb can you please review this and change if necessary and request re-review afterwards (only if changes are performed)? Thank you! |
…-extension into update-help-center-url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some comments though:
- I feel like some of those hardcoded URLs should use the constants from
zendesk-url.js
- Every mention (in the code) of "zendesk" should probably be renamed to "support" (or something close to that), as well as filenames!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24286 +/- ##
========================================
Coverage 65.19% 65.19%
========================================
Files 1405 1405
Lines 55571 55571
Branches 14592 14592
========================================
Hits 36229 36229
Misses 19342 19342 ☔ View full report in Codecov by Sentry. |
Builds ready [f663a24]
Page Load Metrics (330 ± 318 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
The MetaMask help center has migrated from using Zendesk to Docusaurus. The old Zendesk URL is no longer in use, and the support.metamask.io domain should be used instead.
Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions.
Also see MetaMask/metamask-mobile#9946.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist