Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update help center URLs #24286

Merged
merged 10 commits into from
Jun 26, 2024
Merged

fix: Update help center URLs #24286

merged 10 commits into from
Jun 26, 2024

Conversation

wtzb
Copy link
Contributor

@wtzb wtzb commented Apr 29, 2024

Description

The MetaMask help center has migrated from using Zendesk to Docusaurus. The old Zendesk URL is no longer in use, and the support.metamask.io domain should be used instead.

Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions.

Also see MetaMask/metamask-mobile#9946.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wtzb
Copy link
Contributor Author

wtzb commented Apr 29, 2024

I have read the CLA Document and I hereby sign the CLA.

@wtzb wtzb marked this pull request as ready for review April 29, 2024 15:10
@wtzb wtzb requested a review from a team as a code owner April 29, 2024 15:10
@DDDDDanica
Copy link
Contributor

Also find some instance can be updated:

  1. ui/helpers/constants/beta.js
  2. builds.yml

BTW is it needed to update links in ui/helpers/constants/zendesk-url.js?

@legobeat
Copy link
Contributor

legobeat commented May 2, 2024

Also find some instance can be updated:

1. `ui/helpers/constants/beta.js`

2. `builds.yml`

BTW is it needed to update links in ui/helpers/constants/zendesk-url.js?

Mentions of https://metamask.zendesk.com also present in these files:

test/env.js
ui/components/app/beta-header/__snapshots__/beta-header.test.js.snap
ui/components/app/modals/confirm-remove-account/__snapshots__/confirm-remove-account.test.js.snap
ui/components/app/modals/customize-nonce/__snapshots__/customize-nonce.test.js.snap
ui/components/multichain/import-account/__snapshots__/json.test.tsx.snap
ui/helpers/constants/common.ts
ui/pages/confirmations/confirmation/templates/__snapshots__/add-ethereum-chain.test.js.snap
ui/pages/keychains/__snapshots__/reveal-seed.test.js.snap
ui/pages/onboarding-flow/create-password/__snapshots__/create-password.test.js.snap
ui/pages/settings/info-tab/info-tab.test.tsx

wtzb and others added 2 commits June 11, 2024 18:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wtzb wtzb requested review from a team as code owners June 11, 2024 17:13
@wtzb
Copy link
Contributor Author

wtzb commented Jun 11, 2024

Hi there @DDDDDanica and @legobeat! I've added additional links, as mentioned. Old support links still using metamask.zendesk.com will no longer function as of this week, so I've replaced these with the correct, modern URLs. Links following the old Zendesk format (support.metamask.io/hc/en-us/...) have also been replaced with the modern versions.

Let me know whether you might need anything else from my end in order to get this live as soon as possible, as currently, a lot of these links are broken.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
DDDDDanica
DDDDDanica previously approved these changes Jun 12, 2024
@DDDDDanica
Copy link
Contributor

LGTM ! Let me know when you have the test fixed.

@wtzb wtzb changed the title Update help center URLs fix: Update help center URLs Jun 12, 2024
sethkfman added a commit to MetaMask/metamask-mobile that referenced this pull request Jun 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
## **Description**
The MetaMask help center has migrated from using Zendesk to Docusaurus.
The old Zendesk URL is no longer in use, and the support.metamask.io
domain should be used instead.

Old support links still using metamask.zendesk.com will no longer
function as of this week, so I've replaced these with the correct,
modern URLs. Links following the old Zendesk format
(support.metamask.io/hc/en-us/...) have also been replaced with the
modern versions.

Also see MetaMask/metamask-extension#24286.

## **Related issues**

N/A

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

N/A

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [*] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [*] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
metamaskbot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Jun 12, 2024
## **Description**
The MetaMask help center has migrated from using Zendesk to Docusaurus.
The old Zendesk URL is no longer in use, and the support.metamask.io
domain should be used instead.

Old support links still using metamask.zendesk.com will no longer
function as of this week, so I've replaced these with the correct,
modern URLs. Links following the old Zendesk format
(support.metamask.io/hc/en-us/...) have also been replaced with the
modern versions.

Also see MetaMask/metamask-extension#24286.

## **Related issues**

N/A

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

N/A

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [*] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [*] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
benjisclowder
benjisclowder previously approved these changes Jun 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 18, 2024
@ccharly
Copy link
Contributor

ccharly commented Jun 18, 2024

Just for the record, we are still using the old URL in some files like:

builds.yml
68:      - SUPPORT_LINK: https://metamask-flask.zendesk.com/hc
69:      - SUPPORT_REQUEST_LINK: https://metamask-flask.zendesk.com/hc/en-us/requests/new

vinistevam
vinistevam previously approved these changes Jun 18, 2024
@benjisclowder
Copy link
Contributor

benjisclowder commented Jun 18, 2024

Just for the record, we are still using the old URL in some files like:

builds.yml
68:      - SUPPORT_LINK: https://metamask-flask.zendesk.com/hc
69:      - SUPPORT_REQUEST_LINK: https://metamask-flask.zendesk.com/hc/en-us/requests/new

@wtzb can you please review this and change if necessary and request re-review afterwards (only if changes are performed)? Thank you!

@wtzb wtzb dismissed stale reviews from vinistevam and matthewwalsh0 via 6db634c June 18, 2024 10:06
benjisclowder
benjisclowder previously approved these changes Jun 18, 2024
jpuri
jpuri previously approved these changes Jun 18, 2024
wtzb and others added 2 commits June 18, 2024 13:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wtzb wtzb dismissed stale reviews from benjisclowder and jpuri via 2bf5559 June 18, 2024 12:01
ccharly
ccharly previously approved these changes Jun 18, 2024
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments though:

  • I feel like some of those hardcoded URLs should use the constants from zendesk-url.js
  • Every mention (in the code) of "zendesk" should probably be renamed to "support" (or something close to that), as well as filenames!

benjisclowder
benjisclowder previously approved these changes Jun 18, 2024
@benjisclowder benjisclowder requested a review from jpuri June 18, 2024 14:25
@wtzb wtzb dismissed stale reviews from benjisclowder and ccharly via f663a24 June 24, 2024 13:34
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (6414137) to head (f663a24).

Files Patch % Lines
app/scripts/lib/snap-keyring/snap-keyring.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24286   +/-   ##
========================================
  Coverage    65.19%   65.19%           
========================================
  Files         1405     1405           
  Lines        55571    55571           
  Branches     14592    14592           
========================================
  Hits         36229    36229           
  Misses       19342    19342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f663a24]
Page Load Metrics (330 ± 318 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69211993617
domContentLoaded9141111
load422219330663318
domInteractive9141111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 343 Bytes (0.01%)

@wtzb wtzb merged commit 9844d1a into develop Jun 26, 2024
74 checks passed
@wtzb wtzb deleted the update-help-center-url branch June 26, 2024 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet