fix: Fix gas estimates

[Gudahtt]

Description

This is a patch of the bug fix included in MetaMask/core#4214. This ensures that the gas estimates we show for the globally selected chain always reflect the estimates for that chain.

Related issues

Fixes #24254

Manual testing steps

(from #24254)

1. Be on network A. Toggle off "estimate balance changes" in settings.
2. Switch to another network that does not have a transaction in the activity list
3. Go through the send flow until you get to the confirm screen. Let the gas update once
4. click "Edit" in the top left corner, to go back to the send screen
5. Reject from the send screen
6. Switch to a network where you already have a confirmed transaction in the activity list
7. Observe in the background console that suggestGasFees network requests are being sent to endpoints for two different chainIds
8. Go through the send flow to the confirm screen
9. Submit when the most recent suggestGasFee network request is to the network that is not the currently selected network
10. You should be able to verify that the transaction was signed and published with incorrect gas values for the current network

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [69b1d6a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (604 ± 445 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	157	96	23	11
		domContentLoaded	10	29	22	4	2
		load	62	2520	604	926	445
		domInteractive	10	29	22	4	2

[danjm]

Here is a video of how this branch successfully prevents simultaneous polling from causing incorrect gas estimates

gas-working.mp4