Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add browser support guidelines #23457

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 13, 2024

Description

A document about browser support guidelines has been added. This document describes our browser support policy, and the notification requirement when updating the minimum supported browser versions. This is not a new policy, it just wasn't written down before now.

Related issues

Relates to #6805

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

A document about browser support guidelines has been added. This
document describes our browser support policy, and the notification
requirement when updating the minimum supported browser versions.

Relates to #6805
@Gudahtt Gudahtt requested a review from a team as a code owner March 13, 2024 13:20
@metamaskbot
Copy link
Collaborator

Builds ready [93e5f9e]
Page Load Metrics (1038 ± 414 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint731831153215
domContentLoaded107029189
load5921761038863414
domInteractive107029189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt merged commit 0604181 into develop Mar 14, 2024
71 of 73 checks passed
@Gudahtt Gudahtt deleted the add-browser-support-guidelines branch March 14, 2024 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants