-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Reorganize test/e2e repo to improve navigation part 1 #23398
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e65bfbf]
Page Load Metrics (1299 ± 338 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23398 +/- ##
========================================
Coverage 68.67% 68.67%
========================================
Files 1106 1106
Lines 43356 43356
Branches 11591 11591
========================================
Hits 29773 29773
Misses 13583 13583 ☔ View full report in Codecov by Sentry. |
LGTM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR is the beginning of a series aimed at reorganizing the
test/e2e
repository to create a structure that is both well-organized and easy to navigate. The goal is to enhance the overall efficiency and accessibility of our e2e tests. This reorganization work will be split into multiple PRs, ensures that each PR remains manageable and easy to review, facilitating better feedback and more efficient integration.In this initial step, I've started by creating multiple folders within the
test/e2e/tests
repo to group tests by feature. This allows for a more intuitive organization, with each set of feature-related tests contained within its own dedicated folder. The tests that were most evidently associated with a specific feature have been sorted into the appropriate new folders. The remaining test cases, which may require further discussion or clarification to assign correctly, will be addressed in future PRs.The reason behind organizing test cases by features is to streamline the ownership of tests, with each feature team being responsible for one or multiple folders related to the features they develop and maintain. This fosters a sense of ownership and aligns testing efforts closely with feature development. I did not create a separate repo for each feature team due to potential maintenance challenges, especially if we have team reorganizations in the future.
Additionally, other files such as helpers, modules, and utility files that support these tests are also planned to be reorganized in the following PRs.
Related issues
Fixes: #23296
Manual testing steps
Check if the organization is logical.
Screenshots/Recordings
Before
Screen.Recording.2024-03-08.at.17.08.42.mov
After
Screen.Recording.2024-03-08.at.17.10.51.mov
Pre-merge author checklist
Pre-merge reviewer checklist