-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update avatarType prop to be optional #23184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthomas13
added
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
needs-ux-ds-review
team-wallet-ux
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
labels
Feb 26, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
changed the title
fix: Update avatarType prop to be optional
fix[#23080]: Update avatarType prop to be optional
Feb 26, 2024
HowardBraham
approved these changes
Feb 26, 2024
vthomas13
changed the title
fix[#23080]: Update avatarType prop to be optional
fix [#23080]: Update avatarType prop to be optional
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23184 +/- ##
========================================
Coverage 68.60% 68.60%
========================================
Files 1096 1096
Lines 43262 43262
Branches 11528 11528
========================================
Hits 29679 29679
Misses 13583 13583 ☔ View full report in Codecov by Sentry. |
vthomas13
changed the title
fix [#23080]: Update avatarType prop to be optional
fix: Update avatarType prop to be optional
Feb 26, 2024
Builds ready [30dde9a]
Page Load Metrics (1265 ± 424 ms)
Bundle size diffs
|
darkwing
approved these changes
Feb 26, 2024
metamaskbot
added
the
release-11.13.0
Issue or pull request that will be included in release 11.13.0
label
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-11.13.0
Issue or pull request that will be included in release 11.13.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing AvatarGroup tsx test failures due to avatarType being a required type
Related issues
Fixes: #23080
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist