Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update avatarType prop to be optional #23184

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Feb 26, 2024

Description

Fixing AvatarGroup tsx test failures due to avatarType being a required type

Open in GitHub Codespaces

Related issues

Fixes: #23080

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Feb 26, 2024
@vthomas13 vthomas13 requested a review from a team as a code owner February 26, 2024 18:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 changed the title fix: Update avatarType prop to be optional fix[#23080]: Update avatarType prop to be optional Feb 26, 2024
@vthomas13 vthomas13 changed the title fix[#23080]: Update avatarType prop to be optional fix [#23080]: Update avatarType prop to be optional Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (cb36096) to head (30dde9a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23184   +/-   ##
========================================
  Coverage    68.60%   68.60%           
========================================
  Files         1096     1096           
  Lines        43262    43262           
  Branches     11528    11528           
========================================
  Hits         29679    29679           
  Misses       13583    13583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vthomas13 vthomas13 changed the title fix [#23080]: Update avatarType prop to be optional fix: Update avatarType prop to be optional Feb 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [30dde9a]
Page Load Metrics (1265 ± 424 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint832011273316
domContentLoaded107933199
load6924741265883424
domInteractive107933199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit dcf585f into develop Feb 26, 2024
82 of 83 checks passed
@darkwing darkwing deleted the avatar-type-lintfix branch February 26, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants