Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Snaps): Add label prop to Snap UI input #23153

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

GuillaumeRx
Copy link
Contributor

Description

I forgot to expose the label prop of the Snap custom UI input component. This PR fixes it.

Manual testing steps

  1. Spin up a custom UI screen with an input with a label
  2. The label should render

Screenshots/Recordings

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner February 23, 2024 14:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Feb 23, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 23, 2024
@GuillaumeRx GuillaumeRx changed the title Add label prop to Snap UI input fix(Snaps): Add label prop to Snap UI input Feb 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [cd75776]
Page Load Metrics (1683 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1103041825326
domContentLoaded978342613
load13881907168316479
domInteractive978342613
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 14 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.52%. Comparing base (d878047) to head (cd75776).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23153   +/-   ##
========================================
  Coverage    68.52%   68.52%           
========================================
  Files         1092     1092           
  Lines        43184    43184           
  Branches     11506    11506           
========================================
  Hits         29591    29591           
  Misses       13593    13593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillaumeRx GuillaumeRx merged commit a8112c8 into develop Feb 23, 2024
72 of 73 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-label-snap-input branch February 23, 2024 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024
@ziedbrini ziedbrini added team-snaps-platform Snaps Platform team and removed team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants