Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly remove setInputState from confirmation template #23147

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 23, 2024

Description

In #22828 we intended to remove setInputState from the values passed in getTemplateValues for confirmations as it is no longer needed. We forgot to remove it from the function itself. This PR fixes that. This makes sure that confirmation templates now again get their data.

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Feb 23, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner February 23, 2024 09:25
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 23, 2024
Mrtenz
Mrtenz previously approved these changes Feb 23, 2024
@FrederikBolding FrederikBolding merged commit 2e91b54 into develop Feb 23, 2024
63 of 66 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-set-input-state branch February 23, 2024 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5f129f9]
Page Load Metrics (1728 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1152791794220
domContentLoaded1679392110
load15072245172816278
domInteractive1679392110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -4 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-11.12.0 Issue or pull request that will be included in release 11.12.0 and removed release-11.13.0 Issue or pull request that will be included in release 11.13.0 labels Mar 5, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.12.0 on PR. Adding release label release-11.12.0 on PR and removing other release labels(release-11.13.0), as PR was cherry-picked in branch 11.12.0.

@ziedbrini ziedbrini added team-snaps-platform Snaps Platform team and removed team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants