fix: Prettier ESLint VSCode extension #23106

HowardBraham · 2024-02-22T01:41:16Z

Description

The Prettier ESLint VSCode extension updated, and now our default formatters don't work anymore
https://marketplace.visualstudio.com/items?itemName=rvest.vs-code-prettier-eslint

The new version requires the package prettier-eslint to be installed.

Related issues

Manual testing steps

Run yarn
Open a file in VSCode and change it so it's formatted incorrectly
Run the formatter
Windows: Shift + Alt + F
Mac: Shift + Option + F

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-22T01:41:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-02-22T01:44:44Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	`0`	5.8 kB	developit
npm/[email protected]	None	`+1`	7.29 kB	sindresorhus
npm/[email protected]	environment	`+8`	684 kB	kentcdodds
npm/[email protected]	environment, filesystem Transitive: shell, unsafe	`+87`	53.4 MB	jounqin
npm/[email protected]	unsafe	`0`	2.26 kB	kamicane
npm/[email protected]	unsafe Transitive: environment, filesystem, shell	`+58`	10.2 MB	ota-meshi

View full report↗︎

socket-security · 2024-02-22T01:44:47Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

dbrans

Thanks for taking care of this!

metamaskbot · 2024-02-22T02:01:50Z

Builds ready [d68fe95]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1759 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	116	328	181	54	26
		domContentLoaded	10	93	38	23	11
		load	1494	2002	1759	133	64
		domInteractive	10	93	38	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 532 Bytes (0.01%)

legobeat · 2024-02-23T04:27:06Z

@SocketSecurity ignore npm/[email protected]

new author ok

codecov · 2024-02-23T04:45:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (4d2c1ff) to head (3a72a3e).
Report is 17 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23106   +/-   ##
========================================
  Coverage    68.50%   68.50%           
========================================
  Files         1089     1089           
  Lines        43076    43076           
  Branches     11480    11480           
========================================
  Hits         29507    29507           
  Misses       13569    13569

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-02-23T04:50:49Z

Builds ready [3a72a3e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1890 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	425	204	86	42
		domContentLoaded	11	83	37	21	10
		load	1547	2269	1890	185	89
		domInteractive	11	83	37	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 532 Bytes (0.01%)

HowardBraham added 2 commits February 21, 2024 15:19

fix: prettier-eslint

ff0aa83

policy changes

d68fe95

HowardBraham added the team-extension-platform label Feb 22, 2024

HowardBraham self-assigned this Feb 22, 2024

HowardBraham changed the title ~~fix: prettier-eslint VSCode extension~~ fix: Prettier ESLint VSCode extension Feb 22, 2024

HowardBraham requested review from dbrans, legobeat and georgewrmarshall February 22, 2024 01:49

dbrans previously approved these changes Feb 22, 2024

View reviewed changes

HowardBraham marked this pull request as ready for review February 22, 2024 01:56

HowardBraham requested review from a team as code owners February 22, 2024 01:56

HowardBraham requested a review from davidmurdoch February 22, 2024 02:05

legobeat added 2 commits February 23, 2024 03:34

use patched [email protected] for eslint@^8.7.0

7969621

yarn dedupe

469e539

legobeat dismissed dbrans’s stale review via 469e539 February 23, 2024 03:35

update lavamoat build policy

3a72a3e

legobeat approved these changes Feb 23, 2024

View reviewed changes

legobeat requested a review from dbrans February 23, 2024 04:51

dbrans approved these changes Feb 23, 2024

View reviewed changes

HowardBraham merged commit e0704de into develop Feb 23, 2024
66 checks passed

HowardBraham deleted the prettier-eslint branch February 23, 2024 16:44

github-actions bot locked and limited conversation to collaborators Feb 23, 2024

metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024

HowardBraham added the contributor experience An issue that impacts, or planned improvement to, the contributor experience. label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Prettier ESLint VSCode extension #23106

fix: Prettier ESLint VSCode extension #23106

HowardBraham commented Feb 22, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Feb 22, 2024

socket-security bot commented Feb 22, 2024 •

edited

Loading

socket-security bot commented Feb 22, 2024 •

edited

Loading

dbrans left a comment

metamaskbot commented Feb 22, 2024

legobeat commented Feb 23, 2024

codecov bot commented Feb 23, 2024

metamaskbot commented Feb 23, 2024

fix: Prettier ESLint VSCode extension #23106

fix: Prettier ESLint VSCode extension #23106

Conversation

HowardBraham commented Feb 22, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 22, 2024

socket-security bot commented Feb 22, 2024 • edited Loading

socket-security bot commented Feb 22, 2024 • edited Loading

Next steps

dbrans left a comment

Choose a reason for hiding this comment

metamaskbot commented Feb 22, 2024

legobeat commented Feb 23, 2024

codecov bot commented Feb 23, 2024

Codecov Report

metamaskbot commented Feb 23, 2024

HowardBraham commented Feb 22, 2024 •

edited by github-actions bot

Loading

socket-security bot commented Feb 22, 2024 •

edited

Loading

socket-security bot commented Feb 22, 2024 •

edited

Loading