-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add optimism arbitrum goerli deprecation warning #23071
Merged
sahar-fehri
merged 3 commits into
develop
from
feat/Add-optimism-arbitrum-goerli-deprecation-warning
Feb 22, 2024
Merged
Feat: add optimism arbitrum goerli deprecation warning #23071
sahar-fehri
merged 3 commits into
develop
from
feat/Add-optimism-arbitrum-goerli-deprecation-warning
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23071 +/- ##
========================================
Coverage 68.48% 68.48%
========================================
Files 1089 1089
Lines 43015 43015
Branches 11462 11462
========================================
Hits 29455 29455
Misses 13560 13560 ☔ View full report in Codecov by Sentry. |
Builds ready [15cb314]
Page Load Metrics (980 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
reviewed
Feb 20, 2024
Builds ready [ef52d61]
Page Load Metrics (1229 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
changed the title
Feat/add optimism arbitrum goerli deprecation warning
Feat: add optimism arbitrum goerli deprecation warning
Feb 20, 2024
darkwing
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Feb 21, 2024
darkwing
approved these changes
Feb 21, 2024
pedronfigueiredo
approved these changes
Feb 22, 2024
gauthierpetetin
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Feb 22, 2024
sahar-fehri
deleted the
feat/Add-optimism-arbitrum-goerli-deprecation-warning
branch
February 22, 2024 13:43
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Feb 22, 2024
metamaskbot
added
the
release-11.12.0
Issue or pull request that will be included in release 11.12.0
label
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-11.12.0
Issue or pull request that will be included in release 11.12.0
team-assets
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a deprecation warning when user switches to Arbitrum goerli or OP goerli testnetwork
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-02-20.at.14.37.07.mov
After
Screen.Recording.2024-02-20.at.14.39.43.mov
Pre-merge author checklist
Pre-merge reviewer checklist