Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add optimism arbitrum goerli deprecation warning #23071

Merged

Conversation

sahar-fehri
Copy link
Contributor

Description

This PR adds a deprecation warning when user switches to Arbitrum goerli or OP goerli testnetwork

Related issues

Fixes:

Manual testing steps

  1. Go to home page
  2. Click Add network
  3. Click Add network Manually
  4. Fill in the input fields with Arbitrum goerli or OP goerli testnet RPC and chainId (or use chainList)
  5. Switch to the entered network
  6. You should see a deprecation warning on the home page

Screenshots/Recordings

Before

Screen.Recording.2024-02-20.at.14.37.07.mov

After

Screen.Recording.2024-02-20.at.14.39.43.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner February 20, 2024 13:41
@sahar-fehri sahar-fehri self-assigned this Feb 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef9e63a) 68.48% compared to head (ef52d61) 68.48%.
Report is 42 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23071   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1089     1089           
  Lines        43015    43015           
  Branches     11462    11462           
========================================
  Hits         29455    29455           
  Misses       13560    13560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [15cb314]
Page Load Metrics (980 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1183231875024
domContentLoaded10103482713
load810126998011354
domInteractive10103482713
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 67 Bytes (0.00%)
  • common: 63 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ef52d61]
Page Load Metrics (1229 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1265182178239
domContentLoaded20126592814
load9791640122916881
domInteractive20126592814
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 11 Bytes (0.00%)
  • common: 63 Bytes (0.00%)

@sahar-fehri sahar-fehri changed the title Feat/add optimism arbitrum goerli deprecation warning Feat: add optimism arbitrum goerli deprecation warning Feb 20, 2024
@sahar-fehri sahar-fehri requested a review from darkwing February 20, 2024 17:22
@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 21, 2024
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2024
@sahar-fehri sahar-fehri merged commit d87b631 into develop Feb 22, 2024
69 checks passed
@sahar-fehri sahar-fehri deleted the feat/Add-optimism-arbitrum-goerli-deprecation-warning branch February 22, 2024 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-assets team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants