Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Multichain: Added connections page #23070

Merged
merged 7 commits into from
Feb 27, 2024
Merged

UX Multichain: Added connections page #23070

merged 7 commits into from
Feb 27, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Feb 20, 2024

1 . This PR is to add the Connections page.
2. Have used Header, Content and Footer Structure
3. This Pr is for the state when metamask is not connected to the site.
4. For the non connected state, I have created a separate component and have a snapshot test for that

NOTE: I have not added the test for connections page. I will add it once I implement the connected state as well.

Related issues

Fixes: planning/2056

Manual testing steps

  1. Run extension with Multichain Feature Flag in Popup View
  2. Click on the globe icon
  3. Check the state when site is not connected.

Screenshots/Recordings

Before

NA

After

Screenshot 2024-02-21 at 9 24 20 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 20, 2024
@NidhiKJha NidhiKJha changed the title (WIP 👷‍♀️ ) UX Multichain: Added connections page UX Multichain: Added connections page Feb 21, 2024
@NidhiKJha NidhiKJha marked this pull request as ready for review February 21, 2024 15:57
@NidhiKJha NidhiKJha requested a review from a team as a code owner February 21, 2024 15:57
@NidhiKJha NidhiKJha added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [62845d9]
Page Load Metrics (1815 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9173820813163
domContentLoaded1284342411
load160625681815209100
domInteractive1284342411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.03 KiB (0.06%)
  • common: 223 Bytes (0.00%)

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 68.50%. Comparing base (bb634d5) to head (aa5f29f).
Report is 13 commits behind head on develop.

❗ Current head aa5f29f differs from pull request most recent head 496b134. Consider uploading reports for the commit 496b134 to get more accurate results

Files Patch % Lines
...nents/multichain/pages/connections/connections.tsx 9.09% 10 Missing ⚠️
ui/components/multichain/app-header/app-header.js 12.50% 7 Missing ⚠️
ui/pages/routes/routes.component.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23070      +/-   ##
===========================================
- Coverage    68.52%   68.50%   -0.02%     
===========================================
  Files         1092     1093       +1     
  Lines        43184    43205      +21     
  Branches     11506    11512       +6     
===========================================
+ Hits         29591    29597       +6     
- Misses       13593    13608      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [5524ab3]
Page Load Metrics (2042 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1063641876933
domContentLoaded1382332010
load159524802042235113
domInteractive1382332010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.03 KiB (0.06%)
  • common: 223 Bytes (0.00%)

Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, aside from one issue where the text was not showing up for non-dapps.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

vthomas13
vthomas13 previously approved these changes Feb 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [aa5f29f]
Page Load Metrics (2440 ± 182 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1523992245627
domContentLoaded1999502512
load180734572440379182
domInteractive1997462311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.03 KiB (0.06%)
  • common: 223 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [496b134]
Page Load Metrics (1875 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8242222310149
domContentLoaded1085312210
load16142227187517283
domInteractive1085312210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.04 KiB (0.06%)
  • common: 223 Bytes (0.00%)

@NidhiKJha NidhiKJha requested a review from vthomas13 February 26, 2024 18:13
@NidhiKJha NidhiKJha merged commit c45edac into develop Feb 27, 2024
65 of 66 checks passed
@NidhiKJha NidhiKJha deleted the fix-2056 branch February 27, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants