-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Multichain: Added connections page #23070
Conversation
Builds ready [62845d9]
Page Load Metrics (1815 ± 100 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23070 +/- ##
===========================================
- Coverage 68.52% 68.50% -0.02%
===========================================
Files 1092 1093 +1
Lines 43184 43205 +21
Branches 11506 11512 +6
===========================================
+ Hits 29591 29597 +6
- Misses 13593 13608 +15 ☔ View full report in Codecov by Sentry. |
Builds ready [5524ab3]
Page Load Metrics (2042 ± 113 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, aside from one issue where the text was not showing up for non-dapps.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [aa5f29f]
Page Load Metrics (2440 ± 182 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [496b134]
Page Load Metrics (1875 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
1 . This PR is to add the Connections page.
2. Have used Header, Content and Footer Structure
3. This Pr is for the state when metamask is not connected to the site.
4. For the non connected state, I have created a separate component and have a snapshot test for that
NOTE: I have not added the test for connections page. I will add it once I implement the connected state as well.
Related issues
Fixes: planning/2056
Manual testing steps
Screenshots/Recordings
Before
NA
After
Pre-merge author checklist
Pre-merge reviewer checklist