-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrading design tokens to v2 #22897
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhy is contributor and author data important?Package does not specify a list of contributors or an author in package.json. Add a author field or contributors array to package.json. What is unstable ownership?A new collaborator has begun publishing package versions. Package stability and security risk may be elevated. Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Builds ready [e9a13c0]
Page Load Metrics (748 ± 15 ms)
Bundle size diffs
|
Builds ready [320b074]
Page Load Metrics (975 ± 27 ms)
Bundle size diffs
|
Description
This PR updates @metamask/design-tokens package to v2. There are not visual changes but upgrade to major version is due to node version upgrade see details in PR here: MetaMask/design-tokens#601
Related issues
Fixes: N/A
Manual testing steps
yarn start
Screenshots/Recordings
Before
Screenshot below shows design tokens stylesheet being loaded
After
Screenshot below shows design tokens stylesheet being loaded as expected after package update
Pre-merge author checklist
Pre-merge reviewer checklist