-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gas fee editing should not be hidden if user has disabled currency rate check #22890
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [7ee42cc]
Page Load Metrics (852 ± 37 ms)
Bundle size diffs
|
Builds ready [848fc7b]
Page Load Metrics (1175 ± 105 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22890 +/- ##
========================================
Coverage 68.51% 68.51%
========================================
Files 1088 1088
Lines 42914 42915 +1
Branches 11426 11427 +1
========================================
+ Hits 29399 29401 +2
+ Misses 13515 13514 -1 ☔ View full report in Codecov by Sentry. |
Missing release label release-11.9.3 on PR. Adding release label release-11.9.3 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.9.3. |
Description
Gas editing button is hidden if user disabled currency rate check option.
Related issues
Fixes: #22872
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist