Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ethjs packages to remove babel-runtime dependency #22859

Merged
merged 9 commits into from
Feb 22, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 7, 2024

Description

Update @metamask/ethjs* packages for new versions built with babel 7 instead of babel 6. This removes the (peer)dependency on deprecated babel-runtime for these packages.

  • Bump @metamask/ethjs* packages to latest
    • Packages are now using bn.js v5 (matching direct dependency of metamask-extension) instead of v4.
  • Bump @metamask/eth-token-tracker from ^7.0.1 to ^7.0.2
  • Bump eth-method-registry from ^3.0.0 to ^4.0.0
    • Changelog
    • No breaking changes affecting metamask-extension
  • Bump @metamask/transaction-controller from ^21.1.0 to ^22.0.0
    • Changelog
    • No breaking changes affecting metamask-extension

Related issues

Depends on

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Feb 7, 2024
Copy link

socket-security bot commented Feb 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: network +3 470 kB lgbot
npm/@metamask/[email protected] Transitive: network +24 7.6 MB lgbot
npm/@metamask/[email protected] Transitive: environment, filesystem, network +124 27.5 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/[email protected] filesystem 0 1.45 MB ldthomas
npm/[email protected] None +21 5.79 MB lgbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@legobeat
Copy link
Contributor Author

legobeat commented Feb 16, 2024

Note: As this PR stands, @metamask/user-operation-controller is still pulling in older versions through transitive dependency on @metamask/transaction-controller.

@metamask/transaction-controller required version per @metamask/user-operation-controller versions

$ nvs -p @metamask/transaction-controller @metamask/user-operation-controller
0.0.0   2023-12-14T19:09:38.724Z        >=16.0.0        null
1.0.0   2024-01-15T14:11:25.886Z        >=16.0.0        ^20.0.0
2.0.0   2024-01-23T21:48:03.387Z        >=16.0.0        ^21.0.0
3.0.0   2024-01-29T17:31:52.062Z        >=16.0.0        ^21.0.1
4.0.0   2024-02-15T23:34:56.424Z        >=16.0.0        ^23.0.0

@metamask/transaction-controller@>=22.0.0 removes the deprecated versions. @metamask/[email protected] contains some wider breaking changes and this upgrade is pending in #22979 .

@legobeat legobeat marked this pull request as ready for review February 19, 2024 01:36
@legobeat legobeat requested review from a team as code owners February 19, 2024 01:36
@legobeat legobeat force-pushed the deps-ethjs branch 2 times, most recently from 217b151 to d8095bd Compare February 20, 2024 10:17
@legobeat legobeat requested a review from a team February 21, 2024 02:36
@legobeat legobeat merged commit 3687b18 into MetaMask:develop Feb 22, 2024
65 of 66 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Mar 1, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.12.0 on PR, as PR was added to branch 11.12.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants