E2e request queuing #22818
Merged
E2e request queuing #22818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent selected networks.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22818 +/- ##
===========================================
+ Coverage 68.49% 68.51% +0.02%
===========================================
Files 1092 1088 -4
Lines 43170 42914 -256
Branches 11512 11426 -86
===========================================
- Hits 29567 29399 -168
+ Misses 13603 13515 -88 ☔ View full report in Codecov by Sentry. |
Builds ready [2600e22]
Page Load Metrics (753 ± 15 ms)
Bundle size diffs
|
Builds ready [add1d9d]
Page Load Metrics (832 ± 31 ms)
Bundle size diffs
|
Builds ready [2f39f3f]
Page Load Metrics (779 ± 22 ms)
Bundle size diffs
|
Builds ready [195fb6a]
Page Load Metrics (778 ± 12 ms)
Bundle size diffs
|
Builds ready [4f97800]
Page Load Metrics (722 ± 16 ms)
Bundle size diffs
|
Builds ready [bbed57f]
Page Load Metrics (811 ± 23 ms)
Bundle size diffs
|
Builds ready [c599f14]
Page Load Metrics (1029 ± 43 ms)
Bundle size diffs
|
adonesky1
reviewed
Feb 14, 2024
| } = require('../../helpers'); | ||
| const { PAGES } = require('../../webdriver/driver'); | ||
|
|
||
| // TODO: Have to turn on the setting every time we want to test the setting!?! |
There was a problem hiding this comment.
We should be able to add this to the fixture no?
There was a problem hiding this comment.
Yes, we should be able to. The issuesis that any type of refresh of the state that happens reverts the request queue setting behavior to default, the setting is off even though it is supposed to be on. This behavior can be replicated in prod with the steps in the next line comment.
BelfordZ
reviewed
Feb 22, 2024
| css: 'p', | ||
| }); | ||
|
|
||
| // TODO: Request Queuing bug when opening both dapps at the same time will have them stuck on the same network, with will be incorrect for one of them. |
There was a problem hiding this comment.
Suggested change
| // TODO: Request Queuing bug when opening both dapps at the same time will have them stuck on the same network, with will be incorrect for one of them. | |
| // TODO: Request Queuing bug when opening both dapps at the same time will have them stuck on the same network, which will be incorrect for one of them. |
also, thats an odd one! defs something to look into. Might be worth making a branch that has a failing test as described here.
BelfordZ
reviewed
Feb 22, 2024
| '[data-testid="page-container-footer-cancel"]', | ||
| ); | ||
|
|
||
| // TODO: No second confirmation from dapp two will show, have to go back to the extension to see the switch chain & dapp two's tx. |
There was a problem hiding this comment.
nice find on getting this to work!
Similar to above, it might be good to have a failing test on a branch so we can track this as things are updated /merged
BelfordZ
approved these changes
Feb 22, 2024
Builds ready [698ab1e]
Page Load Metrics (1911 ± 87 ms)
Bundle size diffs
|
adonesky1
approved these changes
Feb 23, 2024
metamaskbot
added
the
release-11.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds e2e tests for the request queuing system. Tests include enable the toggle settings, sending a tx from a different selected/global network which results in a switch chain request, and request queuing for multiple daps on different networks.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1404
Manual testing steps
yarn && yarn build:testyarn test:e2e:single test/e2e/tests/request-queuing/enable-queuing.spec.js --browser=chromeyarn test:e2e:single test/e2e/tests/request-queuing/switch-network.spec.js --browser=chromeyarn test:e2e:single test/e2e/tests/request-queuing/multiple-networks-dapps-txs.spec.js --browser=chromeyarn test:e2e:chrome && yarn test:e2e:firefoxfor a bonus.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist