Fix incorrect warnings when adding a chain from a dapp

[danjm]

Description

When a user adds a chain from a dapp, they will see warnings that the currency symbol is incorrect, even though it is correct.

Part of the problem was that the pendingConfirmation variable inside of fetchSafeChainsList was undefined when it should not be. I guess it closed over the original value or something like that? I didn't verify. This PR corrects it by explictly passing the updated pendingConfirmations variable to fetchSafeChainList

The other problem was that useAlertState was calling getTemplateAlerts twice, without resetting the alert state. On the first call, alerts were being set in state because the request to chainId.network had not yet resolved. This PR fixes it by ensuring that that useAlertState does not call getTemplateAlerts before the fetch to chainId.network has resolved (when this confrimation type is an add ethereum chain approval)

Related issues

An example of the problem can be seen by going to https://chainlist.org/?search=cro and adding Cronos Mainnet to metamask, only to see warnings that the currency symbol is incorrect even though it is correct.

Manual testing steps

1. Go to https://chainlist.org/?search=cro
2. Add Cronos mainnet to metamask
3. The confirmation window should open with an add ethereum chain confirmation. There should be no warnings
4. Reject the confirmation
5. Open the dev console and paste the below code, and press enter. The confirmation window should open with an add ethereum chain confirmation. There should be warnings about the currency symbol
6. Reject the confirmation
7. Modify the below code so that "symbol": "cra", becomes "symbol": "cro",, paste it in the dev console and press enter. There should be no warnings in the new confirmation window

await window.ethereum.request({
  "method": "wallet_addEthereumChain",
  "params": [
    {
      "blockExplorerUrls": [
        "https://blockscout.com/poa/xdai/"
      ],
      "nativeCurrency": {
        "name": "CRO",
        "symbol": "cra",
        "decimals": 18
      },
      "rpcUrls": [
        "https://evm.cronos.org",
        null
      ],
      "chainId": "0x19",
      "chainName": "Cronos Mainnet"
    }
  ]
});

Before

cronos-fail.mp4

After

cronos-pass.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3f113bd) 67.94% compared to head (9df0c45) 67.90%.

Files	Patch %	Lines
ui/pages/confirmation/confirmation.js	66.67%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22309      +/-   ##
===========================================
- Coverage    67.94%   67.90%   -0.04%     
===========================================
  Files         1067     1067              
  Lines        41290    41296       +6     
  Branches     11087    11090       +3     
===========================================
- Hits         28054    28041      -13     
- Misses       13236    13255      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [9df0c45]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1259 ± 141 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	408	184	84	40
		domContentLoaded	11	191	78	72	34
		load	847	1930	1259	293	141
		domInteractive	11	191	78	72	34

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 194 Bytes (0.00%)
• common: 0 Bytes (0.00%)